345488 - bad transformation of a SVG text on the "textPath"

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Martin Hejral]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.7) Gecko/20050414
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; cs; rv:1.8.1b1) Gecko/20060710 Firefox/2.0b1

"textPath" should be transformed first and THEN glyphs placed on the transformed path 


Reproducible: Always

Steps to Reproduce:
try this code
---
<defs>
<path id="krivka"
d="M 300 200
C 200 100 300 0 400 00
C 550 00 600 300 700 200
C 800 100 900 100 900 100"
transform="scale(1 -1)" />
</defs>

<circle cx="500" cy="100" r="10"/>
<use xlink:href="#krivka" fill="none" stroke="red" />
<text font-family="'Times CE', 'Times New Roman', serif" 
font-size="72" font-weight="normal" fill="blue" >
<textPath xlink:href="#krivka" method="stretch" >
text 
<tspan dy="-30" fill="red" >
nahoru, 
</tspan>
<tspan dy="30">
dolù a tak dále
</tspan>
</textPath>
</text>

Actual Results:  
see image

Expected Results:  
see image

Comment 1

[Martin Hejral]

Attachment: expected output

Comment 2

[Martin Hejral]

Attachment: Firefox 2b1 incorrect output

Comment 3

[Martin Hejral]

Attachment: test case

Comment 4

[tor]

Attachment: apply appropriate transform

Comment 5

[Robert Longson [:longsonr]]

Comment on attachment 230158 [details] [diff] [review]
apply appropriate transform

>+
>+//----------------------------------------------------------------------
>+// nsSVGContainerFrame methods:
>+
>+already_AddRefed<nsIDOMSVGMatrix>
>+nsSVGTextPathFrame::GetCanvasTM()
>+{
>+  nsCOMPtr<nsIDOMSVGMatrix> xform = nsSVGTextPathFrameBase::GetCanvasTM();

Nit: I'd rather this variable was called matrix (c.f. nsSVGUtils.cpp) or transform.

r=longsonr whatever you chose.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 230158 [details] [diff] [review]
apply appropriate transform

+  nsIDOMSVGMatrix* retval = xform.get();
+  NS_IF_ADDREF(retval);
+  return retval;

Instead, do

  nsIDOMSVGMatrix* retval = nsnull;
  xform.swap(retval);
  return retval;

Comment 7

[tor]

Attachment: Version for checkin - adjusted per comments

Comment 8

[tor]

Checked into trunk.

Comment 9

[tor]

Attachment: new trunk behavior

Hmm, looks like we're still reading the spec differently.

Comment 10

[tor]

Attachment: different approach, seems to agree with spec more

Comment 11

[tor]

Attachment: testcase with nonuniform scale

Comment 12

[tor]

Checked in on trunk.

Comment 13

[tor]

Attachment: branch approach experiment (not working)