Closed Bug 3455 Opened 26 years ago Closed 25 years ago

[PP] mac/linux, dual toolbars appear after surfing

Categories

(Core Graveyard :: Tracking, defect, P1)

Product:
Core Graveyard
Component:
Tracking
Platform:
All
Mac System 8.5
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mikepinkerton, Assigned: pierre)

References

(
URL
)

Details

(Whiteboard: waiting for working linux build in order to verify) 

To reproduce in apprunner (doesn't happen in viewer)
- go to http://www.city.net
- go back
- go forward
- resize if necessary

You will now see the content area that was city.net replaced by a duplicate set
of toolbars. The 2nd set of toolbars is non-operational, but if you do things
like mouse over the real toolbars at the top, you see the feedback in BOTH sets
of toolbars.

Hyatt and I will double check if this is a frame-creation problem or a content
creation problem today, but we think it is most likely layout related. We'll toss
if over the wall if we can verify we are doing everything correct to the extent
of our knowledge (rickg is cc'd for this reason).
Assignee: hyatt → rickg
I set a breakpoint on the toolbar creation method and it is only being called
twice at startup (which is expected -- there are two toolbars). This leads hyatt
and I to believe that since the correct frames are being created, it's not a
toolkit or content model problem, but must be a layout problem.

Reassigning to rickg. It's a nasty one, though, since it prevents going to
certain webpages (why things like city.net and news.com seem to exhibit this bug
could be a starting point).

Adding hyatt to cc list.
Adding myself to the CC list
Severity: normal → major
Yesterday and today's mac build shows this consistently on http://www.city.net
you don't even need to surf much
Target Milestone: M4
rick,  the sporadic appearance of this during the verfication periods
each day causes confusion at best, and tree opening delays at worst.

Can you look at this.  Seems to happen mostly on Mac but has also been
observed on linux.

Putting on the M4 radar.
There is another bug about city.net (#2804) which says that it freezes on load
80% of the time. The weird thing is that, exactly as the present bug, it
regularly disappears and reappears.
Summary: mac/linux, dual toolbars appear after surfing → [PP} mac/linux, dual toolbars appear after surfing
Not sure if this is the same problem, but on Linux, when apprunner starts, it
creates the toolbar and the other chrome except for the menu, creates the
content window, creates a toolbar inside the content window which looks quite
similar to the main toolbar, deletes the toolbar inside the content window, then
creates the menubar.  (Each step is quite slow so it's easy to watch it happen
even on a fast machine.)  This is when running apprunner with no arguments, not
pointing at city.net or any other unusual page.
This is definitely related. but further surfing you can make that second toolbar
be a permanant fixture (till you go to a different site that doesn't have this
effect.)
It really looks like a layout problem, but what do I know.
When we do see this problem on macos, I've placed breakpoints in the toolbar
creation routines, and those "phantom" toolbars really aren't being created as
far as i can tell. the only toolbars that are actually created are the real ones,
and the 2nd set are just figments of layout's overactive imagination.

Now linux may be a bit different, but that's my experience on macos.
Assignee: rickg → pierre
Pierre -- can you please confirm that this still exists?
Assignee: pierre → pinkerton
I can't reproduce it but since I never saw that problem, I may not be the best
person to verify that it's fixed. Reassigned to pinkerton.
Assignee: pinkerton → trudelle
i know it still happens on linux. I'm pretty sure it still happens on mac. I
shouldn't be the owner of this bug since it's not an apprunner problem (the
toolbars really aren't there, verified in debugger).

reassigning to peter.
How is it not an AppRunner problem?  Does it now occur in Viewer?  Who should own
this bug?
Target Milestone: M4 → M5
moving to m5, still needs an owner
I just saw this when I ran Demo10 in apprunner. 100% repro on 4/7/99 build.

So this is still happening, and we still have no idea where they come from. I
think it's a rendering problem since the toolbars really aren't there, so it's
not a problem with the xulframes or content model. It's very hard to point
fingers, though since we really have no idea why they appear and why it's so
intermittant, but when it happens on a page for a given build, it always will
happen...until somthing else is tweaked and they show up reliably on a different
page...sigh...
Assignee: trudelle → pierre
So, since Pierre reassigned to verify that it exists, now that is confirmed I'm
reassigning it back to him.
Summary: [PP} mac/linux, dual toolbars appear after surfing → [PP] mac/linux, dual toolbars appear after surfing
Since I could no longer reproduce the problem as described, I asked Mike
Pinkerton to have a look. Below are his comments.

------
On Mac (debug build, from this morning)

If i go to test11 and roll over any of the button in the chrome, i can
see the dual toolbars momentarily and then the correct page redraws on top.

On linux (debug, from this morning)

If i go to test9, every frame has the extra toolbars drawn before the
frames load. Once things load, it's ok. They're also there before the
very first page is loaded. You can certainly see them when you resize
the window.

I can't seem to get it to replace the entire content area with the
toolbars like before, but they're obviously there. Maybe it's a gworld
not being wiped clean, but its still strange.
------
Status: NEW → ASSIGNED
Even though I havent looked into this problem in detail, I have a feeling it
might have something to do with the offscreen buffer being used to draw a view
at the wrong time.

The toolbar images might just happen to be in the offscreen buffer, which for
some reason is copied to the content area.

One thing to try would be to turn DOUBLE_BUFFER off in nsViewManager.cpp and see
what happens.
Target Milestone: M5 → M6
The problem apparently comes from the positioning and clipping when calling
CopyOffScreenBits(). It can't be fixed from M5 (or at least not without taking
the risk of bigger regressions): pushing to M6.
Target Milestone: M6 → M5
Related to #2236: back to M5
Target Milestone: M5 → M6
Uh oh: I talked too fast. After all, it looks like this one won't be fixed as
part of #2236.

I'll have a look later but it's not worth holding the release in hostage for it.
Back to M6 again.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
In fact, this bug should have gone away as part of #2236. It wasn't because I
ignored a compiler warning in my checkin this morning. It's fixed now.
Status: RESOLVED → VERIFIED
Looks good...marking Verified.
URL: http://www.city.net → http://www.foxnews.com
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
sorry, pierre, but this now happens again on www.foxnews.com.

reopening bug.
clearing resolution. this is with a build from 6/15/99.
Target Milestone: M6
clearing milestone.
QA Contact: leger → claudius
Updating QA Contact
as of 1999061514 Linux still (again?) does it as well. The only difference is that on Linux the second toolbar doesn't mimic the
mouseovers on the first toolbar like Mac does.
Looking at WinNT, with the same build, you can create a similar effects by resizing the window a little while on loading this page.
The top part of the content gets repeated twice with a little bit of the toolbar mixed in for good measure.
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Fixed again. Checked in Wed 06/16 at 9pm.
Four bugs were related to each other and fixed at the same time:
3455: [PP] mac/linux, dual toolbars appear after surfing.
6989: Multiple window drawing gets messed up.
6678: [PP]clipping/port problems in child dialogs.
5560: [PP] CornerView displays garbage.

The missing image on FoxNews is a separate problem (8371).
Target Milestone: M7
Depends on: 8416
Whiteboard: waiting for working linux build in order to verify
this is VERIFIED for Mac 1999061708 and WinNT 1999061708 but i'm waiting on bug 8416 for Linux
Status: RESOLVED → VERIFIED
VERIFIED for Linux with 1999061808
Moving all Apprunner bugs past and present to Other component temporarily whilst
don and I set correct component.  Apprunner component will be deleted/retired
shortly.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.