345502 - PRNG Power up Self test required

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement)

Description

[glen beasley]

Comment 1

[glen beasley]

Attachment: RNG power up self test

Comment 2

[Wan-Teh Chang]

Comment on attachment 230206 [details] [diff] [review]
RNG power up self test

r=wtc. The XKey, XSeed, Q, rng_known_GENX, and
rng_known_DSAX arrays should be declared "static const".

Comment 3

[glen beasley]

Enter passphrase for key '/home/gb134726/.ssh/id_dsa':
Checking in fipstest.c;
/cvsroot/mozilla/security/nss/lib/softoken/fipstest.c,v  <--  fipstest.c
new revision: 1.13.2.3; previous revision: 1.13.2.2
done

Comment 4

[Wan-Teh Chang]

The patch was also checked in on the NSS trunk (NSS 3.12).

Comment 5

[glen beasley]

Attachment: make code portable for all platforms

Comment 6

[Wan-Teh Chang]

Comment on attachment 230966 [details] [diff] [review]
make code portable for all platforms

This patch exposes a bug in the previous patch that
I overlooked.  Some of the arrays have the wrong sizes.

FIPS_DSA_BASE_LENGTH should be 32 bytes (256-bits).

XKey, XKeyValue, and XSeed should be 32 bytes.

rng_known_DSAX should be 20 bytes (DSA_SUBPRIME_LEN).

Please submit a new patch that fixes these array size
problems.  Thanks.

Comment 7

[glen beasley]

Attachment: fix array sizes

Comment 8

[Wan-Teh Chang]

I checked in the patch "fix array sizes" on the NSS trunk (3.12)
and NSS_3_11_BRANCH (3.11.3).

Checking in fipstest.c;
/cvsroot/mozilla/security/nss/lib/softoken/fipstest.c,v  <--  fipstest.c
new revision: 1.17; previous revision: 1.16
done

Checking in fipstest.c;
/cvsroot/mozilla/security/nss/lib/softoken/fipstest.c,v  <--  fipstest.c
new revision: 1.13.2.4; previous revision: 1.13.2.3
done