PRNG Power up Self test required

RESOLVED FIXED in 3.11.3

Status

NSS
Libraries
--
enhancement
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: glen beasley, Assigned: glen beasley)

Tracking

3.11.2
3.11.3
x86
SunOS

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

12 years ago
 
(Assignee)

Updated

12 years ago
Assignee: nobody → glen.beasley
Severity: normal → enhancement
(Assignee)

Comment 1

12 years ago
Created attachment 230206 [details] [diff] [review]
RNG power up self test
Attachment #230206 - Flags: review?(wtchang)

Comment 2

12 years ago
Comment on attachment 230206 [details] [diff] [review]
RNG power up self test

r=wtc. The XKey, XSeed, Q, rng_known_GENX, and
rng_known_DSAX arrays should be declared "static const".
Attachment #230206 - Flags: review?(wtchang) → review+
(Assignee)

Comment 3

12 years ago
Enter passphrase for key '/home/gb134726/.ssh/id_dsa':
Checking in fipstest.c;
/cvsroot/mozilla/security/nss/lib/softoken/fipstest.c,v  <--  fipstest.c
new revision: 1.13.2.3; previous revision: 1.13.2.2
done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.11.2

Comment 4

12 years ago
The patch was also checked in on the NSS trunk (NSS 3.12).
Target Milestone: 3.11.2 → 3.11.3
(Assignee)

Updated

12 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

12 years ago
Created attachment 230966 [details] [diff] [review]
make code portable for all platforms
Attachment #230206 - Attachment is obsolete: true
Attachment #230966 - Flags: review?(wtchang)

Comment 6

12 years ago
Comment on attachment 230966 [details] [diff] [review]
make code portable for all platforms

This patch exposes a bug in the previous patch that
I overlooked.  Some of the arrays have the wrong sizes.

FIPS_DSA_BASE_LENGTH should be 32 bytes (256-bits).

XKey, XKeyValue, and XSeed should be 32 bytes.

rng_known_DSAX should be 20 bytes (DSA_SUBPRIME_LEN).

Please submit a new patch that fixes these array size
problems.  Thanks.
Attachment #230966 - Flags: review?(wtchang) → review-
(Assignee)

Comment 7

12 years ago
Created attachment 231057 [details] [diff] [review]
fix array sizes
Attachment #230966 - Attachment is obsolete: true
(Assignee)

Updated

12 years ago
Attachment #231057 - Flags: review?(wtchang)

Updated

12 years ago
Attachment #231057 - Flags: review?(wtchang) → review+

Comment 8

12 years ago
I checked in the patch "fix array sizes" on the NSS trunk (3.12)
and NSS_3_11_BRANCH (3.11.3).

Checking in fipstest.c;
/cvsroot/mozilla/security/nss/lib/softoken/fipstest.c,v  <--  fipstest.c
new revision: 1.17; previous revision: 1.16
done

Checking in fipstest.c;
/cvsroot/mozilla/security/nss/lib/softoken/fipstest.c,v  <--  fipstest.c
new revision: 1.13.2.4; previous revision: 1.13.2.3
done
Status: REOPENED → RESOLVED
Last Resolved: 12 years ago12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.