345584 - Build broken for nsTypeAheadFind.cpp

Status: RESOLVED FIXED

(SeaMonkey :: Find In Page, defect)

Description

[Alfred Peng]

"nsTypeAheadFind.cpp", line 397: Error: Ambiguous "?:" expression, second operand of type "nsCOMPtr<nsISelectionController>" and third operand of type "int" can be converted to one another.
1 Error(s) detected.
gmake[1]: *** [nsTypeAheadFind.o] Error 1

Comment 1

[Alfred Peng]

Attachment: Patch v1

Comment 2

[Boris Zbarsky [:bzbarsky]]

*getter_AddRefs(selectionController) will always be null.  Is that what we want here?

I'd think we rather want selectionController.get().

That said, I can't really review this code; I'm not a peer for the module, and don't really know the code in this file.

Comment 3

[Alfred Peng]

Attachment: Patch v2

(In reply to comment #2)
> *getter_AddRefs(selectionController) will always be null.  Is that what we want
> here?

hmm... null? From the following definition?
nsISupports*&
operator*()
{
  return *(mTargetSmartPtr.StartAssignment());
}

Comment 4

[Leon Sha]

*** Bug 345697 has been marked as a duplicate of this bug. ***

Comment 5

[Boris Zbarsky [:bzbarsky]]

StartAssignment() nulls out the pointer (after releasing the previous value, if any).  It has to; otherwise you'd leak whatever the previous value was.

Comment 6

[Peter Kasting]

This is definitely the correct patch, someone with CVS access can check in.

Also I need to remember to get this checked in on branch when bug 344337 goes in on branch.

Comment 7

[Alfred Peng]

=> Please help me check in the patch. Thanks.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/components/typeaheadfind/src/nsTypeAheadFind.cpp 	1.24