345593 - can not modify existing event

Status: VERIFIED FIXED

(Calendar :: Tasks, defect)

Description

[Damian Szczepanik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060722 Calendar/0.3a2+

Can not modify events that exist
It is possible to modify new event, created in this build

This is major functionality

Reproducible: Always

Steps to Reproduce:
1. open event created in previous build
2. press OK, to close Edit Event dialog
   -> no effect
Actual Results:  
JS Console:

Error: flushItem DB error: not an error
Source File: file:///C:/Documents%20and%20Settings/Damian/Pulpit/sunbird/components/calStorageCalendar.js
Line: 1548

Error: kCalIDateTime is not defined
Source File: file:///C:/Documents%20and%20Settings/Damian/Pulpit/sunbird/components/calStorageCalendar.js
Line: 1712

Error: kCalIDateTime is not defined
Source File: file:///C:/Documents%20and%20Settings/Damian/Pulpit/sunbird/components/calStorageCalendar.js
Line: 1712

Error: kCalIDateTime is not defined
Source File: file:///C:/Documents%20and%20Settings/Damian/Pulpit/sunbird/components/calStorageCalendar.js
Line: 1712

Expected Results:  
support event that was created and worked with previous version

I can creatte new event and modify it. The problem is with event that exists (created in previous build)

Comment 1

[Damian Szczepanik]

Attachment: event

Comment 2

[Stefan Sitter [:ssitter]]

Attachment: fix missed places

The patch in Bug 345119 removed kCalIDateTime but does not fixed all places where it was used.

Comment 3

[Joey Minta]

Comment on attachment 230288 [details] [diff] [review]
fix missed places

r=jminta thanks for the patch!

Comment 4

[Joey Minta]

Need someone with a more stable connection than I have to land this.

Comment 5

[Martijn Wargers (dead)]

Checking in calStorageCalendar.js;
/cvsroot/mozilla/calendar/providers/storage/calStorageCalendar.js,v  <--  calSto
rageCalendar.js
new revision: 1.88; previous revision: 1.87
done

Checked in on trunk.

Comment 6

[Joey Minta]

(In reply to comment #5)
> Checked in on trunk.
> 
Martijn, thanks!  All calendar patches land immediately on both trunk and branch since they are not part of the build.  Can you land on 1_8 too, please?

Comment 7

[Martijn Wargers (dead)]

Oh, I didn't know that.

Checking in calStorageCalendar.js;
/cvsroot/mozilla/calendar/providers/storage/calStorageCalendar.js,v  <--  calSto
rageCalendar.js
new revision: 1.61.2.17; previous revision: 1.61.2.16
done

Checked in on the 1.8.1 branch.

Comment 8

[Stefan Sitter [:ssitter]]

(In reply to comment #5)
> Checking in calStorageCalendar.js;
> /cvsroot/mozilla/calendar/providers/storage/calStorageCalendar.js,v  <-- 
> calSto
> rageCalendar.js
> new revision: 1.88; previous revision: 1.87
> done
> 
> Checked in on trunk.
> 

Nit: Please mention the patch author and not the bug reporter in the check in comment next time ;-)

Comment 9

[Martijn Wargers (dead)]

(In reply to comment #8)
> Nit: Please mention the patch author and not the bug reporter in the check in
> comment next time ;-)

Oops! Sorry about that.

Comment 10

[Martijn Wargers (dead)]

Let me at least assign this bug to the right person then. (I just should not do any check-ins that late at night, I guess)

Comment 11

[Damian Szczepanik]

(In reply to comment #10)
> Let me at least assign this bug to the right person then.
Thanks - I was quite surprised why this bug was assigned to me - now looks clear, thanks :)

Comment 12

[Damian Szczepanik]

works

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060723 Calendar/0.3a2+