Closed
Bug 345606
Opened 18 years ago
Closed 18 years ago
Print dialog broken [Error: getCompositeCalendar is not defined]
Categories
(Calendar :: Printing, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: ssitter, Assigned: jminta)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.72 KB,
patch
|
mvl
:
first-review+
|
Details | Diff | Splinter Review |
Print dialog broken [Error: getCompositeCalendar is not defined] Steps to Reproduce: 1. Start Sunbird, select events 2. Select 'File -> Print...' command 3. Select print options, press OK button Actual Results: Nothing happens. Error message shown in console: Error: getCompositeCalendar is not defined Source File: chrome://calendar/content/printDialog.js Line: 105 Works in Calendar/0.3a2+ (2006072007) Fails in Calendar/0.3a2+ (2006072108)
Reporter | ||
Comment 1•18 years ago
|
||
The patch from Bug 337941 introduced getCompositeCalendar().
Blocks: 337941
Assignee | ||
Comment 2•18 years ago
|
||
(In reply to comment #1) > The patch from Bug 337941 introduced getCompositeCalendar(). > Not so much introduced it, but rather moved it from calendarUtils.js to calendar-views.js, breaking the include here. Note that what we really wanted here all along is window.opener.getCompositeCalendar(). Otherwise, you'll get the wrong instance of the composite, which causes bugs I've seen mentioned in the newsgroups.
Assignee | ||
Comment 3•18 years ago
|
||
This is a local diff of the fix for this bug. It should apply, but since I don't have a good enough connection to get a real diff, let me know if it fails.
Comment 4•18 years ago
|
||
Comment on attachment 230391 [details] [diff] [review] local diff fix r=mvl
Attachment #230391 -
Flags: first-review?(mvl) → first-review+
Assignee | ||
Comment 5•18 years ago
|
||
patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 6•18 years ago
|
||
vefyfied with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060820 Calendar/0.3a2+
Assignee | ||
Updated•18 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•