345606 - Print dialog broken [Error: getCompositeCalendar is not defined]

Status: VERIFIED FIXED

(Calendar :: Printing, defect)

Description

[Stefan Sitter [:ssitter]]

Print dialog broken [Error: getCompositeCalendar is not defined]

Steps to Reproduce:
1. Start Sunbird, select events
2. Select 'File -> Print...' command
3. Select print options, press OK button

Actual Results:
Nothing happens. Error message shown in console:
    Error: getCompositeCalendar is not defined
    Source File: chrome://calendar/content/printDialog.js Line: 105

Works in Calendar/0.3a2+ (2006072007)
Fails in Calendar/0.3a2+ (2006072108)

Comment 1

[Stefan Sitter [:ssitter]]

The patch from Bug 337941 introduced getCompositeCalendar().

Comment 2

[Joey Minta]

(In reply to comment #1)
> The patch from Bug 337941 introduced getCompositeCalendar().
> 
Not so much introduced it, but rather moved it from calendarUtils.js to calendar-views.js, breaking the include here.  Note that what we really wanted here all along is window.opener.getCompositeCalendar(). Otherwise, you'll get the wrong instance of the composite, which causes bugs I've seen mentioned in the newsgroups.

Comment 3

[Joey Minta]

Attachment: local diff fix

This is a local diff of the fix for this bug.  It should apply, but since I don't have a good enough connection to get a real diff, let me know if it fails.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 230391 [details] [diff] [review]
local diff fix

r=mvl

Comment 5

[Joey Minta]

patch checked in.

Comment 6

[Damian Szczepanik]

vefyfied with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060820 Calendar/0.3a2+