345665 - nsKeygenHandler calls nsITokenDialogs ::ChooseToken with NULL context

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

nsKeygenHandler::GetSlotWithMechanism calls nsITokenDialogs::ChooseToken with NULL context interface requestor, even though it's handed an irq itself which it could pass on.
(This might be theoretical since I can't seem to find any way to actually get my nsITokenDialogs implementation called... how can I test this??)

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: fix

Comment 2

[Christian Persch (GNOME) (away; not receiving bug mail)]

Comment on attachment 230368 [details] [diff] [review]
fix

Picking reviewer based on cvs history, I apologise if I picked you in error.

Comment 3

[Kai Engert (:KaiE:)]

> I can't seem to find any way to actually get 
> my nsITokenDialogs implementation called... how can I test this??

You can trigger a key generation by using an html form that contains the keygen tag, for example you could try http://kuix.de/misc/test3/

Comment 4

[Kai Engert (:KaiE:)]

Comment on attachment 230368 [details] [diff] [review]
fix

Your patch is reasonable, thanks for catching this.

r=kengert

Comment 5

[Kai Engert (:KaiE:)]

Thanks to reed for noticing this got never checked in.

Comment 6

[Reed Loden [:reed]]

Does this patch need sr= approval? If not, I'll just check it in, but I wasn't sure...

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 230368 [details] [diff] [review]
fix

sr=dveditz

Comment 8

[Kai Engert (:KaiE:)]

Patch checked in, marking fixed.

Thanks Christian!

Comment 9

[Kai Engert (:KaiE:)]

Reopening bug. All patches that got checked in to trunk yesterday are being backed out, because it's unclear which patch has caused a performance regression.

Comment 10

[Reed Loden [:reed]]

Relanded.

Checking in security/manager/ssl/src/nsKeygenHandler.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsKeygenHandler.cpp,v  <--  nsKeygenHandler.cpp
new revision: 1.47; previous revision: 1.46
done