345774 - hang when closing the info-bar in Add-ons dialog

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Jo Hermans]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b1) Gecko/20060723 BonEcho/2.0b1
running on Mac OS X 10.2.8

I just did an extensions update, and I saw a 'No updates were found' info-bar. When I closed the bar by clicking on the right hand X, the application hangs with  a spinning-wheel-of-dead, and I had to force-quit. When I close the whole Add-ons dialog, it works though. I could repeat it every time.

I tried to use 'sample' to see where it hang, and I saw this stack at the top every time (I'll attach a complete trace in a minute) :
    2000 Thread_0e03
      2000 _sigtramp
        2000 _Z27fcStackDumpCollectorCreatormPciPS_
          2000 _Z15FCProcessSignaliP22UNIX_EXCEPTION_CONTEXT
            2000 _ZN15spSpiralNubCore22HandleProgramExceptionEP22SPIRAL_TRIGGER_
CONTEXT
              2000 _ZN15spSpiralNubCore7CollectEP22SPIRAL_TRIGGER_CONTEXTh
                2000 _ZN19spCollectionManager7CollectEP15spKeyDataStreamP22SPIRA
L_TRIGGER_CONTEXT
                  2000 _ZN14spEnvCollector7CollectER8BlackBoxP15spKeyDataStreamP
22SPIRAL_TRIGGER_CONTEXT
                    2000 strchr
                      2000 strchr [STACK TOP]


Shaver told me that this is due to Talkback, that's why I file it here. I didn't found any other reports.

Comment 1

[Jo Hermans]

Attachment: sample-report

Comment 2

[Marcia Knous [:marcia]]

Not seen using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b1) Gecko/20060724 BonEcho/2.0b1. This is a relatively new profile, with few extensions. I will try with my long standing Firefox profile to see if I can produce. I am running OS X 10.3.9.

Comment 3

[Zach Lipton [:zach]]

Moving to extension manager per rob_strong.

Comment 4

[Jo Hermans]

I tried it with a clean profile, and this time I got a Talkback window : incident TB21376208G

nsXMLDocument::QueryInterface()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/content/xml/document/src//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/content/xml/document/src/nsXMLDocument.cpp, line 194]
nsXULDocument::QueryInterface()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/content/xul/document/src//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/content/xul/document/src/nsXULDocument.cpp, line 483]
nsCOMPtr_base::assign_from_qi()   nsGlobalWindow::GetPrincipal()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/dom/src/base//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/dom/src/base/nsGlobalWindow.cpp, line 830]
nsScriptSecurityManager::doGetObjectPrincipal()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/caps/src//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/caps/src/nsScriptSecurityManager.cpp, line 848]
nsScriptSecurityManager::GetFunctionObjectPrincipal()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/caps/src//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/caps/src/nsScriptSecurityManager.cpp, line 2023]
nsScriptSecurityManager::GetPrincipalAndFrame()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/caps/src//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/caps/src/nsScriptSecurityManager.cpp, line 2078]
nsScriptSecurityManager::GetSubjectPrincipal()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/caps/src//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/caps/src/nsScriptSecurityManager.cpp, line 2119]
nsScriptSecurityManager::CheckPropertyAccessImpl()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/caps/src//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/caps/src/nsScriptSecurityManager.cpp, line 615]
nsScriptSecurityManager::CanAccess()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/caps/src//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/caps/src/nsScriptSecurityManager.cpp, line 2861]
....


hmmmm ... I don't know what's more important now, a hang with a old profile, or a crash with a clean profile. And Marcia can't reproduce with a newer OS-version.

Comment 5

[Zach Lipton [:zach]]

Nominating as a blocker per rob_strong. The relevant factor here is a "too much recursion" error that occurs whenever the close button is clicked. This is apparently causing a crash on some platforms.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Rob, can you give us an assessment of impact vs. time to fix? The fact that this seems to be OS X 10.2 only makes me wonder if we really need to block on it.

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(In reply to comment #4)
> I tried it with a clean profile, and this time I got a Talkback window :
> incident TB21376208G

The more interesting thing in this crash is the many levels of recursion with the following cycle:

nsObserverService::NotifyObservers()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/xpcom/ds//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/xpcom/ds/nsObserverService.cpp, line 848]
_XPTC_InvokeByIndex()
XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode)()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/js/src/xpconnect/src//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/js/src/xpconnect/src/xpcwra]
XPC_WN_CallMethod()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/js/src/xpconnect/src//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp, line 1450]
js_Invoke()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/js/src//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/js/src/jsinterp.c, line 1349]
js_Interpret()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/js/src//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/js/src/jsinterp.c, line 4084]
js_Invoke()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/js/src//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/js/src/jsinterp.c, line 1368]
nsXPCWrappedJSClass::CallMethod()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/js/src/xpconnect/src//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp, line 1417]
PrepareAndDispatch()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/xpcom/reflect/xptcall/src/md/unix//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_ppc_rhapsody.cpp, line 18]
SharedStub()
nsObserverService::NotifyObservers()  [/builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/build/unifox/ppc/xpcom/ds//builds/tinderbox/Fx-Mozilla1.8/Darwin_8.7.0_Depend/mozilla/xpcom/ds/nsObserverService.cpp, line 848]


Is this specific to OS X 10.2?

Comment 8

[Robert Strong (they/them - no direct email)]

This affects all OS's though the crash appears to be Mac OS X 10.2 specific. This was caused by a foolish assumption on my part and I have a patch in hand that I will submit shortly.

Comment 9

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 230657 [details] [diff] [review]
patch

r=sspitzer, robert explained this face to face.

Comment 11

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Comment 12

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH

Comment 13

[Jo Hermans]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b1) Gecko/20060728 BonEcho/2.0b1

Verified as fixed. I've tried both profiles that I mentioned above, the one that hung, and the one that crashed.