Closed
Bug 345787
Opened 18 years ago
Closed 18 years ago
config.mk uses $(USERNAME)
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
(Keywords: fixed1.8.1, regression)
Attachments
(1 file)
766 bytes,
patch
|
mrbkap
:
review+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
I noticed the other day that when I logged into my machine remotely that my DEBUG_mrbkap code wasn't being built. Some investigation revealed that the problem is that it depends on the $(USERNAME) environment variable being present in the environment. As far as I can tell, this variable isn't officially documented in any places, and doesn't appear to be set in OSX's bash. On the other hand, we can use $(USER), which is at least mentioned in the bash manpage, and is set in all environments that I can test easily. This was introduced as part of one of the checkins for bug 312238 (though it isn't in any of the patches in that bug). Brendan, do you remember why you made that change?
Assignee | ||
Comment 1•18 years ago
|
||
Comment 2•18 years ago
|
||
I'm a happy Macbook user now. When I was a Windows luser, I had terrible trouble with Cygwin defining USER to include space ("Brendan Eich"), screwing up my debug builds. I think that local hack crept in by mistake, but I never learned how to avoid such pain. Don't care to know, now! /be
Assignee | ||
Comment 3•18 years ago
|
||
Comment on attachment 230502 [details] [diff] [review] Use $USER Brendan meant to stamp this.
Attachment #230502 -
Flags: review?(brendan) → review+
Assignee | ||
Comment 4•18 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•18 years ago
|
Flags: in-testsuite-
Comment 5•18 years ago
|
||
Comment on attachment 230502 [details] [diff] [review] Use $USER No-brainer for 1.8 branch developer sanity. /be
Attachment #230502 -
Flags: approval1.8.1?
Updated•18 years ago
|
Attachment #230502 -
Flags: approval1.8.1? → approval1.8.1+
Assignee | ||
Updated•18 years ago
|
Keywords: fixed1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•