345787 - config.mk uses $(USERNAME)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

I noticed the other day that when I logged into my machine remotely that my DEBUG_mrbkap code wasn't being built. Some investigation revealed that the problem is that it depends on the $(USERNAME) environment variable being present in the environment. As far as I can tell, this variable isn't officially documented in any places, and doesn't appear to be set in OSX's bash.

On the other hand, we can use $(USER), which is at least mentioned in the bash manpage, and is set in all environments that I can test easily.

This was introduced as part of one of the checkins for bug 312238 (though it isn't in any of the patches in that bug). Brendan, do you remember why you made that change?

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Use $USER

Comment 2

[Brendan Eich [:brendan]]

I'm a happy Macbook user now.  When I was a Windows luser, I had terrible trouble with Cygwin defining USER to include space ("Brendan Eich"), screwing up my debug builds.  I think that local hack crept in by mistake, but I never learned how to avoid such pain.  Don't care to know, now!

/be

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 230502 [details] [diff] [review]
Use $USER

Brendan meant to stamp this.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Fixed.

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 230502 [details] [diff] [review]
Use $USER

No-brainer for 1.8 branch developer sanity.

/be