345848 - Drag and drop of tasks isn't possible in the calender view

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Andreas Treumann]

It's not possible to drag a task to a later start time or to a different day in the calendar view.

Output of the JavaScript Console:

Error: instance.startDate has no properties
Source File: chrome://calendar/content/calendar-views.js
Line: 109

Comment 1

[Joey Minta]

Attachment: startDate || entryDate

I can't emphasize enough how awesome it is to have this unified now.

Patch does the standard startDate || entryDate foo when we try to modify a task in the views.

Comment 2

[Joey Minta]

Comment on attachment 230687 [details] [diff] [review]
startDate || entryDate

-                var startDiff = instance.startDate.subtractDate(aOccurrence.startDate);
+                var instanceStart = instance.startDate || instance.entryDate;
+                var occStart = aOccurrence.startDate || aOccurrence.entryDate;
+                var startDiff = instanceStart.subtractDate(occStart);
                 aNewStartTime.addDuration(startDiff);
-                var endDiff = instance.endDate.subtractDate(aOccurrence.endDate);
+                var instanceEnd = instance.endDate || instance.dueDate;
+                var occEnd = aOccurrence.endDate || aOccurrence.dueDate;
+                var endDiff = instanceEnd.subtractDate(occEnd);
                 aNewEndTime.addDuration(endDiff);
Add a little bit of comment here to make this easier to read.

Comment 3

[Joey Minta]

Attachment: startDate || entryDate v2

without the bitrot and with mroe comments this time.

Comment 4

[Joey Minta]

Comment on attachment 231598 [details] [diff] [review]
startDate || entryDate v2

@@ -219,55 +232,58 @@ function getStyleSheet(aStyleSheetPath) 
 // category (and hence doesn't have a uri), we set the border color.  If
 // it's a calendar, we set the background color
I don't want anything below this point.

r=dmose for the top bit.

Comment 5

[Joey Minta]

patch checked in.

Comment 6

[Damian Szczepanik]

vefyfied with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060820 Calendar/0.3a2+

Comment 7

[Damian Szczepanik]

Litmus testcase 2595 created