Closed Bug 345848 Opened 18 years ago Closed 18 years ago

Drag and drop of tasks isn't possible in the calender view

Categories

(Calendar :: Calendar Frontend, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: andreas.treumann, Assigned: jminta)

Details

Attachments

(1 file, 1 obsolete file)

It's not possible to drag a task to a later start time or to a different day in the calendar view.

Output of the JavaScript Console:

Error: instance.startDate has no properties
Source File: chrome://calendar/content/calendar-views.js
Line: 109
Component: Lightning Only → Calendar Views
Attached patch startDate || entryDate (obsolete) — Splinter Review
I can't emphasize enough how awesome it is to have this unified now.

Patch does the standard startDate || entryDate foo when we try to modify a task in the views.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #230687 - Flags: first-review?(dmose)
Comment on attachment 230687 [details] [diff] [review]
startDate || entryDate

-                var startDiff = instance.startDate.subtractDate(aOccurrence.startDate);
+                var instanceStart = instance.startDate || instance.entryDate;
+                var occStart = aOccurrence.startDate || aOccurrence.entryDate;
+                var startDiff = instanceStart.subtractDate(occStart);
                 aNewStartTime.addDuration(startDiff);
-                var endDiff = instance.endDate.subtractDate(aOccurrence.endDate);
+                var instanceEnd = instance.endDate || instance.dueDate;
+                var occEnd = aOccurrence.endDate || aOccurrence.dueDate;
+                var endDiff = instanceEnd.subtractDate(occEnd);
                 aNewEndTime.addDuration(endDiff);
Add a little bit of comment here to make this easier to read.
Attachment #230687 - Flags: first-review?(dmose) → first-review-
without the bitrot and with mroe comments this time.
Attachment #230687 - Attachment is obsolete: true
Attachment #231598 - Flags: first-review?(dmose)
Comment on attachment 231598 [details] [diff] [review]
startDate || entryDate v2

@@ -219,55 +232,58 @@ function getStyleSheet(aStyleSheetPath) 
 // category (and hence doesn't have a uri), we set the border color.  If
 // it's a calendar, we set the background color
I don't want anything below this point.

r=dmose for the top bit.
Attachment #231598 - Flags: first-review?(dmose) → first-review+
patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
vefyfied with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060820 Calendar/0.3a2+
Status: RESOLVED → VERIFIED
QA Contact: lightning → views
Whiteboard: [litmus testcase wanted]
Litmus testcase 2595 created
Whiteboard: [litmus testcase wanted]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: