345865 - filename and mediatype elements for <upload> are not set in instance

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Steve Speicher]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060719 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060719 Minefield/3.0a1

According to spec 8.3.1(filename) and similarly in 8.3.2(mediatype) states:

"Binding attributes on optional element filename specify the location in the instance for the parent element upload, when activated, to place the filename for the chosen binary resource."

Both values are echoed but this happens regardless of the output elements.  So appears the instance nodes are not being updated.

Reproducible: Always

Comment 1

[Steve Speicher]

Attachment: testcase

Comment 2

[Steve Speicher]

should also note that this is a non-normative testcase from the w3c suite, so should have lower priority

Comment 3

[aaronr]

This is a regression.  This worked in 0.5.  Looks like the patch for bug 275453 is what screwed it up.  Though that went into the tree in October so that doesn't make sense.  Hmmmm...  Pretty simple fix, though.

Comment 4

[aaronr]

(In reply to comment #3)
> This is a regression.  This worked in 0.5.  Looks like the patch for bug 275453
> is what screwed it up.  Though that went into the tree in October so that
> doesn't make sense.  Hmmmm...  Pretty simple fix, though.
> 

My mistake.  The patch that got this working was for bug 275453.  The patch that broke it was for bug 300591.  Stopped setting the bound value of the filename and mediatype elements and instead set the node value of the elements directly.  I think all I have to do is change it back.  I just got to make sure I don't cause any other regression by doing this.

Comment 5

[aaronr]

Attachment: patch

putting back in the nsXFormsUtils::SetSingleNodeBindingValue function that Allan removed in bug 300591.  I think that he thought it only set the node value for the node passed in.  What it does is resolve the single node binding for the xforms element that is passed in and THEN sets the node value for that resolved bound node.  Doing it this way means that we don't have to make xf:filename and xf:mediatype full blown xforms controls.

Comment 6

[Allan Beaufour]

Comment on attachment 230621 [details] [diff] [review]
patch

Yeah, that seems to be my bad.

>   /**
>+   * Convenience method for doing XPath evaluations to set string value
>+   * for an element.
>+   * Returns PR_TRUE if the evaluation succeeds.
>+   */
>+  static NS_HIDDEN_(PRBool)
>+    SetSingleNodeBindingValue(nsIDOMElement *aElement, const nsAString &aValue,
>+                              PRBool *aChanged);

Although looking at the comment, I can see why I was confused. Could you please change the comment so it actually says what the function does :) The return value description is also wrong.

Comment 7

[aaronr]

Attachment: patch w/ Allan's comments addressed

Comment 8

[aaronr]

checked into trunk

Comment 9

[aaronr]

checked into 1.8.0 branch on 2006/09/21

Comment 10

[aaronr]

checked into 1.8 branch on 2006/11/21