345923 - [max os x] all tabs menu has too much space to the left of the favicons

Status: RESOLVED WONTFIX

(Firefox :: Tabbed Browser, defect)

Description

[(not reading, please use [e-mail] instead)]

[max os x] all tabs menu has too much space to the left of the favicons

the pc version does not have this extra space.

let me attach two screen shots.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: pinstripe screen shot

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: winstripe screen shot

Comment 3

[Mark Mentovai]

By design - that's how Mac menus are suposed to look.  We're now matching the native appearance exactly, except a real native app would use a checkmark instead of boldfacing to indicate the current selection.  The blank space to the left of the icon would be used for a checkmark.  I understand that the reason that's not done now is that winstripe can't gracefully handle both an icon and a checkmark on a single menu item.

Comment 4

[(not reading, please use [e-mail] instead)]

> By design - that's how Mac menus are suposed to look.  We're now matching the
> native appearance exactly, except a real native app would use a checkmark
> instead of boldfacing to indicate the current selection.

I checked safari, and its bookmarks menu has the space and the favicon, as you point out.  I also see the checkmark in safari's tab overflow chevron menu.

> The blank space to
> the left of the icon would be used for a checkmark.  I understand that the
> reason that's not done now is that winstripe can't gracefully handle both an
> icon and a checkmark on a single menu item.

right.

but it can be done on winstripe, if we extend the menuitem binding to allow for two images.  (See https://bugzilla.mozilla.org/attachment.cgi?id=229119 for an example.)

but a UI decision was made to use bold, instead of the extra space (for a check / radio).  see bug #343251 for the discussion.

mark (and mconnor) do you think I should log a mac only bug about using a check, instead of bold?

Comment 5

[Peter Kasting]

(In reply to comment #4)
> mark (and mconnor) do you think I should log a mac only bug about using a
> check, instead of bold?

If there's already a consistent OS standard for this, then I'd think we'd want it... part of why we debated how to do things before was because there doesn't really seem to be a win32 standard for this.  (AFAIK on win32 most dropdown lists have no icons and use checkmarks or bullets to indicate selection, depending; IE7 used a check in place of the favicon.)

Comment 6

[Mark Mentovai]

> mark (and mconnor) do you think I should log a mac only bug about using a
> check, instead of bold?

I think so.  The boldfacing feels very out of place on the Mac.  Same goes for the search engine drop-down, by the way.

Comment 7

[Mark Mentovai]

FYI: I just dealt with a related issue in bug 46177, and another one in bug 345739.  Some Moz code is fond of adding a checkmark icon when it should really be setting the checked attribute.  The difference is imperceptible on win32, but in the two cases I'm referencing, it can cause empty blank spaces or double checkmarks on the Mac.

Comment 8

[Mark Mentovai]

Re comments 4-6, Seth, did you file a followup bug for that?

Comment 9

[(not reading, please use [e-mail] instead)]

> Re comments 4-6, Seth, did you file a followup bug for that?

I just did, see bugs #347461 and #347462