(This is based on StringCheesian's proposal on f.m.o.) 1. This would be very handy for switching the engine for 'Search <selected engine> for <selected text>' searches (see bug 203959). 2. This would probably be more discoverable and more memorable than Ctrl+Up/Ctrl+Down -- and perhaps more convenient as well, for those who focus the search bar with the mouse (rather than using Ctrl+K). Perhaps this would apply only to the engine icon itself.
Can't seem to find a simmilar bug after a few searches so marking this as new... if anyone else finds one please re-mark.
Created attachment 231744 [details] [diff] [review] Patch This works whenever the mouse is over the search bar. I'm wondering whether this needs a UI-review first, though.
What happens to mousewheel events when the typeahead drop-down is showing? Do they still get sent to that scrollbar?
(In reply to comment #3) > What happens to mousewheel events when the typeahead drop-down is showing? Do > they still get sent to that scrollbar? > Do you mean the drop down with search history and suggestions? The mousewheel still controls the scrollbar, and the engine doesn't change. The engine only changes when the mouse is over the search logo, search field, or submit button.
This would be particularly nice with the new search-engine button that landed on the branch a few days ago. :)
Created attachment 240912 [details] [diff] [review] Updated patch Changed the patch to keep it up-to-date with changes on the trunk.
Comment on attachment 240912 [details] [diff] [review] Updated patch >Index: search.xml >+ <handler event="DOMMouseScroll" >+ phase="capturing" >+ action="this.selectEngine(event, (event.detail > 0));"/> >+ </handlers> > </handlers> This extra </handlers> makes this not work, r=me with this removed.
Created attachment 240983 [details] [diff] [review] Fix bad copy and paste Yikes, had a bad copy and paste in that one. Sorry! r=gavin.
Comment on attachment 240983 [details] [diff] [review] Fix bad copy and paste mconnor's concerned that people might accidentally switch their search engine with this, and not understand how to get it back, but I'm less worried about that edge case and think this will help more than hinder. We should watch out for bug and anecdotal reports of his concern, though.
Checking in browser/components/search/content/search.xml; /cvsroot/mozilla/browser/components/search/content/search.xml,v <-- search.xml new revision: 1.109; previous revision: 1.108 done
Litmus Triage team: Tomcat will create a testcase for this
verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b2pre) Gecko/2007120704 Minefield/3.0b2pre also created a litmus testcase of this.
This was changed to Cmd+scroll in bug 410603.
For consistency sake can this be extended to the search context menu? Is that another bug? I used to rely on this add-on on the past https://addons.mozilla.org/en-US/firefox/addon/3696 and I'm gld this is being integrated.