Closed Bug 346110 Opened 18 years ago Closed 18 years ago

enterprise calendar features

Categories

(Calendar :: General, enhancement)

Product:
Calendar
Component:
General
Platform:
All
Windows XP
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Lightning 0.3

People

(Reporter: michael.buettner, Assigned: michael.buettner)

Details

Attachments

(3 files)

prototype-pref patch v1
756 bytes, patch
dbo
: first-review+
dmosedale
: second-review+
Details | Diff | Splinter Review
add-files patch v1
6.33 KB, patch
dbo
: first-review+
dmosedale
: second-review+
Details | Diff | Splinter Review
dialog-switch-on patch v1
1.75 KB, patch
dbo
: first-review+
dmosedale
: second-review+
Details | Diff | Splinter Review 
This bug will introduce the necessary bits and pieces to incorporate the upcoming enterprise features in the calendar code.

Please see the appropriate newsgroup discussion on this topic for further details: http://groups.google.com/group/mozilla.dev.apps.calendar/browse_thread/thread/714ea7cc43f0e532/af152041ceb06651#af152041ceb06651
Attached patch prototype-pref patch v1 — — Splinter Review 
this patch introduces the new 'prototype'-pref. see http://wiki.mozilla.org/Calendar:Enterprise_Features for further details.
Attachment #231556 - Flags: first-review?(daniel.boelzle)
Attached patch add-files patch v1 — — Splinter Review 
this patch adds the relevant new files from the prototypes folder to the appropriate jar.mn for lightning. see
http://wiki.mozilla.org/Calendar:Enterprise_Features for further details.
Attachment #231557 - Flags: first-review?(daniel.boelzle)
Attached patch dialog-switch-on patch v1 — — Splinter Review 
this patch uses the eventdialog implemented in prototypes/wcap for item editing depending on the 'calendar.prototypes.wcap'-pref. see
http://wiki.mozilla.org/Calendar:Enterprise_Features for further details.
Attachment #231558 - Flags: first-review?(daniel.boelzle)
Comment on attachment 231556 [details] [diff] [review]
prototype-pref patch v1

r=dbo
Attachment #231556 - Flags: first-review?(daniel.boelzle) → first-review+
Comment on attachment 231557 [details] [diff] [review]
add-files patch v1

r=dbo
Attachment #231557 - Flags: first-review?(daniel.boelzle) → first-review+
Comment on attachment 231558 [details] [diff] [review]
dialog-switch-on patch v1

As lillmatt pointed out, there are pref helpers in calendarUtils.js, namely getPrefSafe() which ought to be used here. r=dbo with that changed.
Comment on attachment 231558 [details] [diff] [review]
dialog-switch-on patch v1

As lillmatt pointed out, there are pref helpers in calendarUtils.js, namely getPrefSafe() which ought to be used here. r=dbo with that changed.
Attachment #231558 - Flags: first-review?(daniel.boelzle) → first-review+
Attachment #231556 - Flags: second-review?(dmose)
Attachment #231557 - Flags: second-review?(dmose)
Attachment #231558 - Flags: second-review?(dmose)
This patch enables additional enterprise features by a pref setting. This was discussed and agreed upon. Because there is no risk involved there is no reason to delay this after the 0.3 release.
Flags: blocking0.3?
Target Milestone: --- → Lightning 0.3
Comment on attachment 231556 [details] [diff] [review]
prototype-pref patch v1

r=dmose
Attachment #231556 - Flags: second-review?(dmose) → second-review+
Comment on attachment 231557 [details] [diff] [review]
add-files patch v1

r=dmose
Attachment #231557 - Flags: second-review?(dmose) → second-review+
Comment on attachment 231558 [details] [diff] [review]
dialog-switch-on patch v1

r=dmose with pref helper comment addressed
Attachment #231558 - Flags: second-review?(dmose) → second-review+
patches checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Bug is marked as FIXED, removing blocking0.3? flag.
Flags: blocking0.3?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: