Last Comment Bug 346132 - Block Popup Windows By Default
: Block Popup Windows By Default
Status: RESOLVED FIXED
[string changes in comment 10]
: fixed1.8.1
Product: Camino Graveyard
Classification: Graveyard
Component: Annoyance Blocking (show other bugs)
: unspecified
: PowerPC Mac OS X
-- enhancement (vote)
: Camino1.5
Assigned To: froodian (Ian Leue)
:
:
Mentors:
Depends on:
Blocks: 343938
  Show dependency treegraph
 
Reported: 2006-07-27 10:33 PDT by Ben Goodger (use ben at mozilla dot org for email)
Modified: 2006-09-22 12:48 PDT (History)
5 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Does the deed (3.30 KB, patch)
2006-09-21 11:45 PDT, froodian (Ian Leue)
hwaara: review+
mikepinkerton: superreview+
Details | Diff | Splinter Review

Description User image Ben Goodger (use ben at mozilla dot org for email) 2006-07-27 10:33:38 PDT
I should not have to edit preferences to make my browser usable. Please, please, please block popups by default!

Pretty much everyone else does this now.
Comment 1 User image Samuel Sidler (old account; do not CC) 2006-07-27 10:36:47 PDT
Agree. Ian, you want to handle this?
Comment 2 User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2006-07-27 13:20:08 PDT
We have some other bugs in the meta that we need to think about when changing the wording on the "first-time" notice.
Comment 3 User image froodian (Ian Leue) 2006-07-27 20:16:01 PDT
Wait, so are we getting rid of the "first-time" notice entirely, or just rewording it (perhaps with better button titles than "ok" and "cancel") so that users can choose the "block popups" option easier?
Comment 4 User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2006-07-27 21:16:19 PDT
Oh, hmm.  I had thought Firefox blocked the popup but still showed a first-time message while blocking, but I just checked 2.0b1 again and it doesn't.

We really need to get the UI right on the bar, then.
Comment 5 User image froodian (Ian Leue) 2006-08-23 18:00:28 PDT
I've been thinking about this, and I really think we should just keep the first-time warning.  It lets users choose what they want to do, which once we have both pop-up blockers, is far from guaranteed.
Comment 6 User image Samuel Sidler (old account; do not CC) 2006-09-13 17:42:35 PDT
(In reply to comment #5)
> I've been thinking about this, and I really think we should just keep the
> first-time warning.  It lets users choose what they want to do, which once we
> have both pop-up blockers, is far from guaranteed.

I agree. Is this a simple change? We should turn this on. :)
Comment 7 User image froodian (Ian Leue) 2006-09-13 17:55:53 PDT
It's already on now, so very easy. ;) WF (per previous comment and IRC).
Comment 8 User image Mike Pinkerton (not reading bugmail) 2006-09-19 08:58:49 PDT
um. what just happened here?
Comment 9 User image Mike Pinkerton (not reading bugmail) 2006-09-19 10:17:47 PDT
ben's point was that the pref should just start out on (blocking popups). I can't imagine any user ever says "no" to that sheet, so just asking them is lame. We should just do the right thing. 

Now that we can unblock popups, it's easy to undo if we get it wrong (which we rarely do). It's not dangerous anymore to block them. 
Comment 10 User image froodian (Ian Leue) 2006-09-21 11:45:03 PDT
Created attachment 239539 [details] [diff] [review]
Does the deed

String changes:  Remove the entire /* popup blocking */ section.
Comment 11 User image Håkan Waara 2006-09-22 02:34:50 PDT
Comment on attachment 239539 [details] [diff] [review]
Does the deed

* Remember to also remove the PopupBlockMsg string.

* Since nothing in our code is now using the browser.popups.showPopupBlocker pref, there's no need to set it to false.  We should reuse it later for the actual "put the blocker in the statusbar"-pref.
Comment 12 User image Håkan Waara 2006-09-22 02:36:28 PDT
Another thing that struck me, when I used a vanilla copy of Camino at a friend's house lately, is that Adblocking is off by default. 

I'd like to see that on by default as well.
Comment 13 User image Stuart Morgan 2006-09-22 06:43:09 PDT
(In reply to comment #12)
> Another thing that struck me, when I used a vanilla copy of Camino at a
> friend's house lately, is that Adblocking is off by default. 
> 
> I'd like to see that on by default as well.

Let's discuss that in another bug.
Comment 14 User image Håkan Waara 2006-09-22 07:14:17 PDT
bug 353810 filed for comment 12.
Comment 15 User image Mike Pinkerton (not reading bugmail) 2006-09-22 12:37:57 PDT
Comment on attachment 239539 [details] [diff] [review]
Does the deed

sr=pink
Comment 16 User image froodian (Ian Leue) 2006-09-22 12:48:00 PDT
Checked in on 1.8branch and trunk

Note You need to log in before you can comment on or make changes to this bug.