Block Popup Windows By Default

RESOLVED FIXED in Camino1.5

Status

Camino Graveyard
Annoyance Blocking
--
enhancement
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Ben Goodger (use ben at mozilla dot org for email), Assigned: froodian (Ian Leue))

Tracking

({fixed1.8.1})

unspecified
Camino1.5
PowerPC
Mac OS X
fixed1.8.1

Details

(Whiteboard: [string changes in comment 10])

Attachments

(1 attachment)

3.30 KB, patch
Håkan Waara
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
I should not have to edit preferences to make my browser usable. Please, please, please block popups by default!

Pretty much everyone else does this now.
Agree. Ian, you want to handle this?
Target Milestone: --- → Camino1.1
We have some other bugs in the meta that we need to think about when changing the wording on the "first-time" notice.
Blocks: 343938
(Assignee)

Comment 3

11 years ago
Wait, so are we getting rid of the "first-time" notice entirely, or just rewording it (perhaps with better button titles than "ok" and "cancel") so that users can choose the "block popups" option easier?
Assignee: nobody → stridey
Oh, hmm.  I had thought Firefox blocked the popup but still showed a first-time message while blocking, but I just checked 2.0b1 again and it doesn't.

We really need to get the UI right on the bar, then.
Component: Preferences → Annoyance Blocking
QA Contact: preferences → annoyance.blocking
(Assignee)

Comment 5

11 years ago
I've been thinking about this, and I really think we should just keep the first-time warning.  It lets users choose what they want to do, which once we have both pop-up blockers, is far from guaranteed.
(In reply to comment #5)
> I've been thinking about this, and I really think we should just keep the
> first-time warning.  It lets users choose what they want to do, which once we
> have both pop-up blockers, is far from guaranteed.

I agree. Is this a simple change? We should turn this on. :)
(Assignee)

Comment 7

11 years ago
It's already on now, so very easy. ;) WF (per previous comment and IRC).
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX
um. what just happened here?
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
ben's point was that the pref should just start out on (blocking popups). I can't imagine any user ever says "no" to that sheet, so just asking them is lame. We should just do the right thing. 

Now that we can unblock popups, it's easy to undo if we get it wrong (which we rarely do). It's not dangerous anymore to block them. 
(Assignee)

Comment 10

11 years ago
Created attachment 239539 [details] [diff] [review]
Does the deed

String changes:  Remove the entire /* popup blocking */ section.
Attachment #239539 - Flags: review?(hwaara)
(Assignee)

Updated

11 years ago
Whiteboard: [string changes in comment 10]

Comment 11

11 years ago
Comment on attachment 239539 [details] [diff] [review]
Does the deed

* Remember to also remove the PopupBlockMsg string.

* Since nothing in our code is now using the browser.popups.showPopupBlocker pref, there's no need to set it to false.  We should reuse it later for the actual "put the blocker in the statusbar"-pref.
Attachment #239539 - Flags: review?(hwaara) → review+

Comment 12

11 years ago
Another thing that struck me, when I used a vanilla copy of Camino at a friend's house lately, is that Adblocking is off by default. 

I'd like to see that on by default as well.

Updated

11 years ago
Attachment #239539 - Flags: superreview?(mikepinkerton)

Comment 13

11 years ago
(In reply to comment #12)
> Another thing that struck me, when I used a vanilla copy of Camino at a
> friend's house lately, is that Adblocking is off by default. 
> 
> I'd like to see that on by default as well.

Let's discuss that in another bug.

Comment 14

11 years ago
bug 353810 filed for comment 12.
Comment on attachment 239539 [details] [diff] [review]
Does the deed

sr=pink
Attachment #239539 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 16

11 years ago
Checked in on 1.8branch and trunk
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.