346132 - Block Popup Windows By Default

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, enhancement)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

I should not have to edit preferences to make my browser usable. Please, please, please block popups by default!

Pretty much everyone else does this now.

Comment 1

[Samuel Sidler (old account; do not CC)]

Agree. Ian, you want to handle this?

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We have some other bugs in the meta that we need to think about when changing the wording on the "first-time" notice.

Comment 3

[froodian (Ian Leue)]

Wait, so are we getting rid of the "first-time" notice entirely, or just rewording it (perhaps with better button titles than "ok" and "cancel") so that users can choose the "block popups" option easier?

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Oh, hmm.  I had thought Firefox blocked the popup but still showed a first-time message while blocking, but I just checked 2.0b1 again and it doesn't.

We really need to get the UI right on the bar, then.

Comment 5

[froodian (Ian Leue)]

I've been thinking about this, and I really think we should just keep the first-time warning.  It lets users choose what they want to do, which once we have both pop-up blockers, is far from guaranteed.

Comment 6

[Samuel Sidler (old account; do not CC)]

(In reply to comment #5)
> I've been thinking about this, and I really think we should just keep the
> first-time warning.  It lets users choose what they want to do, which once we
> have both pop-up blockers, is far from guaranteed.

I agree. Is this a simple change? We should turn this on. :)

Comment 7

[froodian (Ian Leue)]

It's already on now, so very easy. ;) WF (per previous comment and IRC).

Comment 8

[Mike Pinkerton (not reading bugmail)]

um. what just happened here?

Comment 9

[Mike Pinkerton (not reading bugmail)]

ben's point was that the pref should just start out on (blocking popups). I can't imagine any user ever says "no" to that sheet, so just asking them is lame. We should just do the right thing. 

Now that we can unblock popups, it's easy to undo if we get it wrong (which we rarely do). It's not dangerous anymore to block them. 

Comment 10

[froodian (Ian Leue)]

Attachment: Does the deed

String changes:  Remove the entire /* popup blocking */ section.

Comment 11

[Håkan Waara]

Comment on attachment 239539 [details] [diff] [review]
Does the deed

* Remember to also remove the PopupBlockMsg string.

* Since nothing in our code is now using the browser.popups.showPopupBlocker pref, there's no need to set it to false.  We should reuse it later for the actual "put the blocker in the statusbar"-pref.

Comment 12

[Håkan Waara]

Another thing that struck me, when I used a vanilla copy of Camino at a friend's house lately, is that Adblocking is off by default. 

I'd like to see that on by default as well.

Comment 13

[Stuart Morgan]

(In reply to comment #12)
> Another thing that struck me, when I used a vanilla copy of Camino at a
> friend's house lately, is that Adblocking is off by default. 
> 
> I'd like to see that on by default as well.

Let's discuss that in another bug.

Comment 14

[Håkan Waara]

bug 353810 filed for comment 12.

Comment 15

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 239539 [details] [diff] [review]
Does the deed

sr=pink

Comment 16

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk