346136 - SWM: Don't Redirect Links Opened With Features to New Tabs

Status: VERIFIED DUPLICATE of bug 338777

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

If a website opens a link with features specified, e.g.:

window.open("goat.html", "GoatWindow", "width=250,height=100,toolbar=no");

Camino needs to open it in a new window, even if Single Window Mode is enabled, i.e. NOT open in a new tab. The reason is that when sites open "consoles" they often specify sizing etc for good reason. When we first had this in Firefox we did it the way Camino does now, and it broke a lot of websites. 

You could retain the current behavior as a hidden pref. 

The way to detect this is to see if the window is opened with "features" - that is the third parameter to window.open. If it is, open it in a new window anyway. If isn't, then you are safe to redirect to a new tab if that's the setting.

Comment 1

[Samuel Sidler (old account; do not CC)]

Dupe of bug 338777?

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Yep.

*** This bug has been marked as a duplicate of 338777 ***