346151 - Want nsIProxiedChannel

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

I think it would be a good idea to expose the proxyInfo that a channel was constructed with on the channel. That way, users can find out exactly where the connection went. The interface would look like:

/**
 * An interface for accessing the proxy info that a channel was constructed with.
 *
 * @see nsIProxiedProtocolHandler
 */
interface nsIProxiedChannel : nsISupports {
  readonly attribute nsIProxyInfo proxyInfo;
};

This should maybe be a cloned proxy info to ensure callers can't mess with the channel's state, although nsIProxyInfo does not currently expose a clone method...

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

OK, so currently nsIHttpChannelInternal has this same attribute, but a more generic way seems more useful, especially as there _are_ other channels that support proxies (although only SOCKS).

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 231041 [details] [diff] [review]
patch

Looks reasonable.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

oh, in case someone wonders about the bug 265780 dependency - the authprompt implementation needs a way to figure out what the proxy was when the PROXY_AUTH flag is set, and this would be a way to provide that.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on trunk