346264 - Make "Restore Session" button wider

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Simon Bünzli]

The "Restore Previous Session" dialog still tempts me to hit the wrong button. I suppose that this is because the "Start New Session" button is wider than the "Restore Session" one. I suggest either renaming "Start New Session" to "Cancel" or rather to rename "Restore Session" to "Restore Previous Session".

BTW: Is there already a bug for rewording the "serious problem" wording as suggested in bug 344852 comment #8?

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

This doesn't block the release of Firefox2.

Comment 2

[Simon Bünzli]

Attachment: "Restore Previous Session" instead of "Restore Session"

I suspect that not only do I associate the left button with the OK button, but also the bigger one.

Since in the general case we currently rather want people to resume their sessions (since the "crashes" might well have been due to Windows shutting down or a chrome crash) so they don't lose too much data, that left button should grow...

Comment 3

[Simon Bünzli]

Mike: Any decision on this issue yet?

Comment 4

[Simon Bünzli]

Comment on attachment 231812 [details] [diff] [review]
"Restore Previous Session" instead of "Restore Session"

This year-old three-line patch still nicely applies. Gavin: In case your overloaded with review-requests - if you can recommend somebody else, I'll take a few requests off your plate.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 231812 [details] [diff] [review]
"Restore Previous Session" instead of "Restore Session"

r=me codewise. I think you'd probably want to explain the reasoning behind the l10n note, it might not be feasible to do this in some languages, and it's really more of an optimization than an actual requirement.

Should still get beltzner or mconnor to approve this; poking them via email/IRC and telling them that it's a simple string change should get better results than relying on review requests :)

Comment 6

[Simon Bünzli]

Attachment: make the non-dataloss button wider

(In reply to comment #5)
> poking them via email/IRC [...] should get better results
Will do, thanks.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 276273 [details] [diff] [review]
make the non-dataloss button wider

Whoops. Sorry, Simon. ui-r+

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 276273 [details] [diff] [review]
make the non-dataloss button wider

This doesn't need approval at this stage.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/sessionstore/src/nsSessionStartup.js 	1.18
mozilla/browser/locales/en-US/chrome/browser/sessionstore.properties 	1.5

Comment 10

[u279076]

in-litmus-
Dialog no longer exists.