Closed Bug 346275 Opened 19 years ago Closed 19 years ago

checksetup.pl should read the "answers" file into a Safe

Categories

(Bugzilla :: Installation & Upgrading, enhancement)

2.23
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: mkanat, Assigned: mkanat)

References

Details

Attachments

(1 file)

Right now checksetup.pl just does a "do $answers". Instead, it should read it into a Safe object and pull out just the $answer hash. I'll also create a read_answers_file subroutine, and start to really get this "reorganize checksetup" thing going.
Attached patch v1Splinter Review
And yet another interdiff in this long string of patches. :-) This works, I tested it with Data::Dumper to see that I was reading in the data correctly. The one thing this changes is that an empty "answers" file will no longer silence checksetup--I suppose that should be relnoted.
Requesting approval directly, as module owner.
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval? → approval+
Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.519; previous revision: 1.518 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: