346363 - setFullYear() (with no arguments) seems to clobber a Date object

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Adam Guthrie]

On 1.5, 1.8, and trunk.

Steps to reproduce:
1. ./run-mozilla.sh ./xpcshell
2. js> var d = new Date()
   js> var foo = new Date()
   js> foo.setFullYear()
   NaN
   js> foo.setFullYear(2006)
   NaN
   js> foo.getFullYear()
   NaN

Results:
Calling setFullYear() without any arguments on a Date object seems to clobber it, not allowing it to be modified anymore.

Expected results:
setFullYear(2006) should be able to set the full year of the Date object.

Comment 1

[Adam Guthrie]

Attachment: regression testcase

Figured I'd have a go at making a regression testcase for this.

Comment 2

[Adam Guthrie]

Attachment: regression testcase (corrected)

Comment 3

[Bob Clary [:bc] (inactive)]

(In reply to comment #2)
> Created an attachment (id=231171) [edit]
> regression testcase (corrected)

Looks good on a quick glance. Lets see what the masters of javascript say before we go further.

Comment 4

[Feng Qian (Google)]

Attachment: patch

It seems someone typed wrong varaible name. The comment says that if it should be setting Year if maxargs is 3. I verified with the first test case, it should work correctly.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 6

[Bob Clary [:bc] (inactive)]

Checking in regress-346363.js;
/cvsroot/mozilla/js/tests/js1_5/Date/regress-346363.js,v  <--  regress-346363.js
initial revision: 1.1

Comment 7

[Bob Clary [:bc] (inactive)]

verified fixed 1.9 _but not 1.8_ window/mac(ppc|tel)/linux 20060803.

Comment 8

[Mike Schroepfer]

Comment on attachment 231184 [details] [diff] [review]
patch 

a=schrep

Comment 9

[Bob Clary [:bc] (inactive)]

This is _not_ fixed on 1.8 and is at risk of missing Firefox 2. Please check this in to MOZILLA_1_8_BRANCH and add the fixed1.8.1 keyword when you have done so.

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

Fixed on the 1.8 branch.

Comment 11

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.1 20060811 windows/mac(ppc|tel)/linux