346725 - DOM Explorer menu bar keyboard navigation issue

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Wayne DeAngelo]

Test environment:
   Windows XP, Firefox 2 (Bon Echo) build 20060731, Microsoft Inspect Objects

Description: 

In the DOM Explorer window, the “View” option is next to “Help”  in the menu bar at the top of the window.  However, when using the Arrow key to move from View to Help, you must press the right arrow key 4 times to move from the View option to the Help option.  It acts as if there are 3 menu items between View and Help.

Steps to recreate:
1. Open DOM Inspector window.  (In Firefox, press Ctrl+Shift+I, or select DOM Inspector from the Tools menu pulldown.)
2. Press Alt key to focus on menu bar.  This will move focus to the “File” menu bar item.
3. Press Right Arrow 3 times to move focus to the “View” menu bar item.
4. Press Right Arrow 4 more times.  The first 3 time, focus goes to some unknown, invisible place.  The 4th time you press Right Arrow, you will see focus reappear on the “Help” menu item. 

Expected results:
1. It should take only one Right Arrow keystroke to move from View to Help.

More information:
Inspect Objects does not show any change in focus during the 3 “phantom” keystrokes between View and Help.

Comment 1

[J. Paul Reed [:preed]]

-> General.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Since DOMi is made to work in both Firefox in SeaMonkey, it overlays menu elements that are only present in SeaMonkey builds, so the menu items are actually there, but they're hidden by http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/xul.css&rev=1.83#285  since they're empty.

Comment 3

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: clean up line length, spaces at end of line, util.dtd for toolboxOverlay.xul

Comment 4

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: eliminate empty children of the menubar

Neil, do you know if this is kosher on Mac? I can have a look tomorrow.

Comment 5

[[e-mail]]

Comment on attachment 464642 [details] [diff] [review]
clean up line length, spaces at end of line, util.dtd for toolboxOverlay.xul

> <!DOCTYPE overlay [
>   <!ENTITY % dtd1 SYSTEM "chrome://inspector/locale/inspector.dtd"> %dtd1;
>-  <!ENTITY % dtd2 SYSTEM "chrome://inspector/content/util.dtd"> %dtd2;
> ]>
I guess it's not worth switching to the short doctype form.
(I wonder when we last used those entities in util.dtd, if at all...)

>       <toolbarbutton id="btnFind" observes="cmd:find" 
Worth killing this trailing space too?

Comment 6

[[e-mail]]

Comment on attachment 464644 [details] [diff] [review]
eliminate empty children of the menubar

>+    if (!kid.childNodes.length) {
Nit: hasChildNodes()

>+    <menupopup id="menu_ToolsPopup"/> <!-- Mac magic -->
Interestingly this element isn't empty for me - Venkman and Layout Debugger both add menuitems to it. But it doesn't seem to affect anything.

>     <menu id="helpMenu"/>  <!-- Firefox -->
Fortunately this meant that I could test the patch ;-)

Comment 7

[Colby Russell :crussell (no longer Mozilla-ing)]

(In reply to comment #5)
> Comment on attachment 464642 [details] [diff] [review]
> clean up line length, spaces at end of line, util.dtd for toolboxOverlay.xul
> 
> > <!DOCTYPE overlay [
> >   <!ENTITY % dtd1 SYSTEM "chrome://inspector/locale/inspector.dtd"> %dtd1;
> >-  <!ENTITY % dtd2 SYSTEM "chrome://inspector/content/util.dtd"> %dtd2;
> > ]>
> I guess it's not worth switching to the short doctype form.

I used to do that, until surkov mentioned that it allowed more DTDs to be added with one-line, although I don't really expect them to change that much.

(In reply to comment #6)
> >+    <menupopup id="menu_ToolsPopup"/> <!-- Mac magic -->
> Interestingly this element isn't empty for me - Venkman and Layout Debugger
> both add menuitems to it. But it doesn't seem to affect anything.

I noticed that, and was going to move it to the end, before I saw that it wasn't causing the problem to stick around.

Pushed with changes:
http://hg.mozilla.org/dom-inspector/rev/a3222031e75b
http://hg.mozilla.org/dom-inspector/rev/d940b5d29da3