Remove platform-specific roles

RESOLVED FIXED

Status

()

RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: aaronlev, Assigned: aaronlev)

Tracking

({access})

Trunk
x86
All
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
This is a followup to bug 341747.

We should expose the same accessible role in nsIAccessible::GetRole(), no matter what platform we're running on.
(Assignee)

Comment 1

12 years ago
Created attachment 231581 [details] [diff] [review]
Remove platform-specific GetRole() code
Attachment #231581 - Flags: review?(ginn.chen)
(Assignee)

Comment 2

12 years ago
Note, this patch assumes that top level windows can have ATK_ROLE_APPLICATOIN/ATK_ROLE_DIALOG instead of ATK_ROLE_FRAME. Please correct me if I'm wrong.
(Assignee)

Updated

12 years ago
Attachment #231581 - Flags: review?(ginn.chen)
(Assignee)

Comment 3

12 years ago
Created attachment 231590 [details] [diff] [review]
More complete patch

After emailing with Bill Haneman, I have this information:
1. ATK_ROLE_APPLICATION is reserved for the root of the hierarchy
2. ATK_ROLE_FRAME and ATK_ROLE_DIALOG are for top level windows

Separate issue, probably need a followup bug:
We currently have no way to support DHTML a11y's wairole:dialog or wairole:application, without breaking Bill's definition of those rules. However, since there currently is no other way and the API doesn't forbid it, we may have little choice. Bill suggested ATK_ROLE_EMBEDDED for applications, but EMBEDDED does not seem to say what is embedded. We need to know whether to treat it as document or UI.
Attachment #231581 - Attachment is obsolete: true
Attachment #231590 - Flags: review?(Evan.Yan)

Comment 4

12 years ago
Comment on attachment 231590 [details] [diff] [review]
More complete patch

r=me

one question:
why we didn't implement nsAppRootAccessible under src/base?

Updated

12 years ago
Attachment #231590 - Flags: review?(Evan.Yan) → review+
(Assignee)

Comment 5

12 years ago
> why we didn't implement nsAppRootAccessible under src/base?
There is no parent accessible to the nsRootAccessible objects in Windows. They are children of the desktop.

(Assignee)

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.