346852 - Remove platform-specific roles

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

This is a followup to bug 341747.

We should expose the same accessible role in nsIAccessible::GetRole(), no matter what platform we're running on.

Comment 1

[Aaron Leventhal]

Attachment: Remove platform-specific GetRole() code

Comment 2

[Aaron Leventhal]

Note, this patch assumes that top level windows can have ATK_ROLE_APPLICATOIN/ATK_ROLE_DIALOG instead of ATK_ROLE_FRAME. Please correct me if I'm wrong.

Comment 3

[Aaron Leventhal]

Attachment: More complete patch

After emailing with Bill Haneman, I have this information:
1. ATK_ROLE_APPLICATION is reserved for the root of the hierarchy
2. ATK_ROLE_FRAME and ATK_ROLE_DIALOG are for top level windows

Separate issue, probably need a followup bug:
We currently have no way to support DHTML a11y's wairole:dialog or wairole:application, without breaking Bill's definition of those rules. However, since there currently is no other way and the API doesn't forbid it, we may have little choice. Bill suggested ATK_ROLE_EMBEDDED for applications, but EMBEDDED does not seem to say what is embedded. We need to know whether to treat it as document or UI.

Comment 4

[Evan Yan]

Comment on attachment 231590 [details] [diff] [review]
More complete patch

r=me

one question:
why we didn't implement nsAppRootAccessible under src/base?

Comment 5

[Aaron Leventhal]

> why we didn't implement nsAppRootAccessible under src/base?
There is no parent accessible to the nsRootAccessible objects in Windows. They are children of the desktop.