346890 - Sunbird is missing PrintPDE.plugin on Mac

Status: RESOLVED FIXED

(Calendar :: Printing, defect)

Description

[Matthew (lilmatt) Willis]

PrintPDE.plugin provides advanced print dialog functionality on the Mac.
We build it, but we're not packaging it currently. 

As a result you see assertions like the following when printing from a debug build on the Mac:

###!!! ASSERTION: LoadPDEPlugIn() failed: 'NS_SUCCEEDED(rv)', file /Users/mwillis/moz/printing/mozilla/embedding/components/printingui/src/mac/nsPrintingPromptServiceX.cpp, line 234


We should package PrintPDE.plugin with Sunbird.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - package the PrintPDE.plugin we already build

Packages the PrintPDE.plugin we already build, similar to how browser, mail, suite, etc. do it.

Comment 2

[Matthew (lilmatt) Willis]

Nominating for blocking0.3

Taking

Comment 3

[Joey Minta]

(In reply to comment #2)
> Nominating for blocking0.3
What's the current impact, other than the assertion?  "Advanced print dialog functionality" doesn't mean much to me.

Comment 4

[Matthew (lilmatt) Willis]

Comment on attachment 231626 [details] [diff] [review]
rev0 - package the PrintPDE.plugin we already build

Moving review to jminta as mvl's on vacation, and jminta and I "made a deal" for a couple reviews

Comment 5

[Joey Minta]

Comment on attachment 231626 [details] [diff] [review]
rev0 - package the PrintPDE.plugin we already build

r=jminta

Comment 6

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

(Removing blocking0.3 nomination)