346912 - print() function name collision

Status: RESOLVED FIXED

(Calendar :: Printing, defect)

Description

[Matthew (lilmatt) Willis]

In bug 345490, I added printUtils.js to allow us to do Page Setup.
Doing so caused a function name collision for "print()" between print() in calendar.js and toolkit/components/printing/content/printUtils.js

We should namespace our own print function.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - renames our print() function to not collide

This patch renames our print() function to not collide with toolkit's.

I intentionally didn't move calPrint() to applicationUtil.js as we likely will want to have a way to access the print selection dialog in Lightning.


Checked for uses at:
http://landfill.mozilla.org/mxr-test/mozilla/search?string=print%28%29&find=%2Fcalendar%2F&filter=

Comment 2

[Matthew (lilmatt) Willis]

taking

Comment 3

[Joey Minta]

Comment on attachment 231644 [details] [diff] [review]
rev0 - renames our print() function to not collide

It goes in calendarUtils., not applicationUtil, but that's already included in the lightning-printing patch.

Comment 4

[Matthew (lilmatt) Willis]

patch checked in on MOZILLA_1_8_BRANCH and trunk

-> FIXED