Last Comment Bug 346914 - Infallible JS_SetPrivate
: Infallible JS_SetPrivate
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: ---
Assigned To: general
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-08-01 13:55 PDT by Igor Bukanov
Modified: 2012-04-06 00:18 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description Igor Bukanov 2006-08-01 13:55:37 PDT
[This is a spin-off of bug 346450 comment 14 , 15 , 16]

Currently many users of JS_SetPrivate check for possible failure of JS_SetPrivate. But this function is infallible so such checks are unnecessary. We should remove such checks and either fix JS_SetPrivate so it would return void or at least document that the function always returns true if backward compatibility issues can not be addressed with preprocessor hacks or something.
Comment 1 Luke Wagner [:luke] 2012-04-06 00:18:37 PDT
Already done.

Note You need to log in before you can comment on or make changes to this bug.