347070 - Implement RepetitionElement for Web Forms 2.0

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Shawn Wilsher :sdwilsh]

Implement as per spec.  Hopefully with XBL/JS.

Comment 1

[Shawn Wilsher :sdwilsh]

So after talking to bz about this on irc, it has been determined that this needs to be implemented in C++ because of issues with XBL.  These may be fixed in XBL2.

Essentially, the properties added by XBL aren't visible to C++ code accessing the DOM initially.  This is why it had to be written in C++.

Comment 2

[Shawn Wilsher :sdwilsh]

Attachment: IDL

Here's the IDL file for the element.  Should save someone some time.

Comment 3

[Alex Vincent [:WeirdAl]]

clarification: display:none breaks XBL bindings right now. :(

Comment 4

[Shawn Wilsher :sdwilsh]

Attachment: v0.1

This isn't done, but it's progress (best that I have it in more that one place).  This will compile with v0.2 on Bug 347007 assuming I got all the files for each patch.

Feedback welcome.

Comment 5

[Shawn Wilsher :sdwilsh]

Attachment: v0.2

Ignore the stuff about nsDOMRepetitionEvent as that code is related to Bug 347007.

Some of this stuff works correctly, but I make no claims to functionality of things that say they don't work.  If you want to provide feedback, by all means do so. :)

Comment 6

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

As per conversations with sicking on irc, I'm going to be breaking this up into much smaller bugs to try to help out the reviewers.

This is just a subset of v0.2, but it's just the function headers and what is needed for the tearoff to work.  This code does in fact work for the tearoff, but obviously none of the functions exist in this patch.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Er....  So what do you want review on?  You can't land that part on its own...

Comment 8

[Lars Gunther]

Repetition has been dropped in HTML 5. Should this bug be marked as WONTFIX?