Closed Bug 347070 Opened 17 years ago Closed 13 years ago

Implement RepetitionElement for Web Forms 2.0


(Core :: DOM: Core & HTML, defect)

Not set





(Reporter: sdwilsh, Unassigned)





(1 file, 3 obsolete files)

Implement as per spec.  Hopefully with XBL/JS.
Assignee: general → comrade693
Blocks: 344614
So after talking to bz about this on irc, it has been determined that this needs to be implemented in C++ because of issues with XBL.  These may be fixed in XBL2.

Essentially, the properties added by XBL aren't visible to C++ code accessing the DOM initially.  This is why it had to be written in C++.
Assignee: comrade693 → general
Keywords: helpwanted
Attached file IDL (obsolete) —
Here's the IDL file for the element.  Should save someone some time.
clarification: display:none breaks XBL bindings right now. :(
Attached patch v0.1 (obsolete) — Splinter Review
This isn't done, but it's progress (best that I have it in more that one place).  This will compile with v0.2 on Bug 347007 assuming I got all the files for each patch.

Feedback welcome.
Assignee: general → comrade693
Attachment #231868 - Attachment is obsolete: true
Keywords: helpwanted
Attached patch v0.2 (obsolete) — Splinter Review
Ignore the stuff about nsDOMRepetitionEvent as that code is related to Bug 347007.

Some of this stuff works correctly, but I make no claims to functionality of things that say they don't work.  If you want to provide feedback, by all means do so. :)
Attachment #232473 - Attachment is obsolete: true
Attached patch v1.0Splinter Review
As per conversations with sicking on irc, I'm going to be breaking this up into much smaller bugs to try to help out the reviewers.

This is just a subset of v0.2, but it's just the function headers and what is needed for the tearoff to work.  This code does in fact work for the tearoff, but obviously none of the functions exist in this patch.
Attachment #234357 - Attachment is obsolete: true
Attachment #234834 - Flags: review?(bzbarsky)
Er....  So what do you want review on?  You can't land that part on its own...
Attachment #234834 - Flags: review?(bzbarsky)
Depends on: 349674
Depends on: 349675
Depends on: 349677
Depends on: 349679
Depends on: 349681
Depends on: 349682
Depends on: 349683
Depends on: 349684
Depends on: 349685
Target Milestone: mozilla1.9beta1 → Future
Component: DOM: HTML → DOM: Core & HTML
QA Contact: ian → general
Assignee: sdwilsh → nobody
Repetition has been dropped in HTML 5. Should this bug be marked as WONTFIX?
Closed: 13 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.