Implement RepetitionElement for Web Forms 2.0

RESOLVED WONTFIX

Status

()

RESOLVED WONTFIX
13 years ago
9 years ago

People

(Reporter: sdwilsh, Unassigned)

Tracking

Trunk
Future
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

13 years ago
Implement as per spec.  Hopefully with XBL/JS.
(Reporter)

Updated

13 years ago
Assignee: general → comrade693
Blocks: 344614
(Reporter)

Comment 1

13 years ago
So after talking to bz about this on irc, it has been determined that this needs to be implemented in C++ because of issues with XBL.  These may be fixed in XBL2.

Essentially, the properties added by XBL aren't visible to C++ code accessing the DOM initially.  This is why it had to be written in C++.
Assignee: comrade693 → general
Keywords: helpwanted
(Reporter)

Comment 2

13 years ago
Created attachment 231868 [details]
IDL

Here's the IDL file for the element.  Should save someone some time.
clarification: display:none breaks XBL bindings right now. :(
(Reporter)

Comment 4

13 years ago
Created attachment 232473 [details] [diff] [review]
v0.1

This isn't done, but it's progress (best that I have it in more that one place).  This will compile with v0.2 on Bug 347007 assuming I got all the files for each patch.

Feedback welcome.
Assignee: general → comrade693
Attachment #231868 - Attachment is obsolete: true
Status: NEW → ASSIGNED
(Reporter)

Updated

13 years ago
Keywords: helpwanted
(Reporter)

Comment 5

13 years ago
Created attachment 234357 [details] [diff] [review]
v0.2

Ignore the stuff about nsDOMRepetitionEvent as that code is related to Bug 347007.

Some of this stuff works correctly, but I make no claims to functionality of things that say they don't work.  If you want to provide feedback, by all means do so. :)
Attachment #232473 - Attachment is obsolete: true
(Reporter)

Comment 6

13 years ago
Created attachment 234834 [details] [diff] [review]
v1.0

As per conversations with sicking on irc, I'm going to be breaking this up into much smaller bugs to try to help out the reviewers.

This is just a subset of v0.2, but it's just the function headers and what is needed for the tearoff to work.  This code does in fact work for the tearoff, but obviously none of the functions exist in this patch.
Attachment #234357 - Attachment is obsolete: true
Attachment #234834 - Flags: review?(bzbarsky)
Er....  So what do you want review on?  You can't land that part on its own...
(Reporter)

Updated

13 years ago
Attachment #234834 - Flags: review?(bzbarsky)
(Reporter)

Updated

13 years ago
Depends on: 349674
(Reporter)

Updated

13 years ago
Depends on: 349675
(Reporter)

Updated

13 years ago
Depends on: 349677
(Reporter)

Updated

13 years ago
Depends on: 349679
(Reporter)

Updated

13 years ago
Depends on: 349681
(Reporter)

Updated

13 years ago
Depends on: 349682
(Reporter)

Updated

13 years ago
Depends on: 349683
(Reporter)

Updated

13 years ago
Depends on: 349684
(Reporter)

Updated

13 years ago
Depends on: 349685
(Reporter)

Updated

12 years ago
Target Milestone: mozilla1.9beta1 → Future

Updated

11 years ago
Component: DOM: HTML → DOM: Core & HTML
QA Contact: ian → general
(Reporter)

Updated

11 years ago
Assignee: sdwilsh → nobody
Status: ASSIGNED → NEW

Comment 8

10 years ago
Repetition has been dropped in HTML 5. Should this bug be marked as WONTFIX?
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.