347085 - url bar vertically expanded by work on bug 337427, yielding white lines above and below yellow area

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Joe Hughes]

The work on bug 337427 apparently expands the height of the location bar by two pixels on Linux systems, which is noticeable as a white line above and below the yellow background of the location bar when visiting an SSL site.

Comment 1

[Joe Hughes]

Attachment: sets height of spacer textbox to 0 in stylesheet

Comment 2

[Adam Guthrie]

Comment on attachment 231843 [details] [diff] [review]
sets height of spacer textbox to 0 in stylesheet

This patch resolves the height issue for me and doesn't regress bug 337427. This can't go into the tree without a review from a module peer, though. 

Also, is there a bug filed for the problem Jesse was seeing on Mac where there's no shadow in the location bar? (This could be totally unrelated, but your patch for bug 337427 was the only one that touched pinstripe during the regression range.)

Comment 3

[Joe Hughes]

(In reply to comment #2)
> (From update of attachment 231843 [details] [diff] [review] [edit])
> This patch resolves the height issue for me and doesn't regress bug 337427.
> This can't go into the tree without a review from a module peer, though. 
> 
> Also, is there a bug filed for the problem Jesse was seeing on Mac where
> there's no shadow in the location bar? (This could be totally unrelated, but
> your patch for bug 337427 was the only one that touched pinstripe during the
> regression range.)

The problem on the Mac may be similar, but I was unable to reproduce it consistently enough to identify a fix that I was confident in.  Could someone attach a before and after screenshot of the effect on the Mac so that I can be sure I'm looking at the right thing (either in this bug or a new one)?

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 231843 [details] [diff] [review]
sets height of spacer textbox to 0 in stylesheet

sr+a=me on behalf of drivers for checkin to 1.8 branch

Comment 5

[Joe Hughes]

landed on branch & trunk