Closed Bug 347116 Opened 19 years ago Closed 19 years ago

Move field-definition code from checksetup.pl into a module

Categories

(Bugzilla :: Installation & Upgrading, enhancement)

2.23
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: mkanat, Assigned: mkanat)

References

Details

Attachments

(1 file)

Right now checksetup.pl does a lot of creation of fields for the fielddefs table in one block. Because of the way we have it structured, it probably actually should just manage that whole table in one block, before the schema changes. Anyhow, it should all be moved into a module, probably Bugzilla::Field.
Attached patch v1Splinter Review
Okay, here it is. I just moved all the code into Bugzilla::Field, because it seemed to make sense for it to be there, and it's not a gigantic chunk of code.
Requesting approval directly, as module owner.
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval? → approval+
Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.535; previous revision: 1.534 done Checking in Bugzilla/Field.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Field.pm,v <-- Field.pm new revision: 1.16; previous revision: 1.15 done Checking in Bugzilla/Install/DB.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/DB.pm,v <-- DB.pm new revision: 1.3; previous revision: 1.2 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: