347211 - Jumpback doesn't work with "Open link in new tab" from link contextual menu

Status: RESOLVED FIXED

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[froodian (Ian Leue)]

1. make sure you have a tab open to the right of the current one
2. control-click on a link and choose "Open Link in New Tab" (using shift-toggle if necessary to make it load in the foreground)
3. close tab

What happens: doesn't jumpback
What should happen: should

This works in the incendiary mammal.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Well, all our discussion has been very specific to "opens a new fg tab via cmd-click or SWM" ;)

Comment 2

[froodian (Ian Leue)]

It's true, and I wasn't sure we should do this at first.  But I think it makes more sense to have it be for "Open a new tab from a link", since that pretty much defines the "mini session" situations that you'd want jumpback for.

Comment 3

[Samuel Sidler (old account; do not CC)]

I'm told it's also what Firefox does...

Comment 4

[froodian (Ian Leue)]

Attachment: Patch

Best.  Patch.  Ever.

Comment 5

[froodian (Ian Leue)]

Err... sorry for not providing enough context to actually see where this is.  it's in |openLinkInNewWindowOrTab|

Comment 6

[Chris Lawson (gone)]

Comment on attachment 232279 [details] [diff] [review]
Patch

r=me

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 232279 [details] [diff] [review]
Patch

sr=pink. landing trunk and branch.

Comment 8

[Mike Pinkerton (not reading bugmail)]

fixed.