Closed Bug 347242 Opened 18 years ago Closed 18 years ago

Strict warnings in notification.xml

Categories

(Toolkit :: UI Widgets, defect)

1.8 Branch
defect
Not set
minor

Tracking

()

VERIFIED FIXED
mozilla1.8.1beta2

People

(Reporter: zeniko, Assigned: whimboo)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

Warning: assignment to undeclared variable n
Source file: chrome://global/content/bindings/notification.xml
Line: 77
 ----------
Warning: assignment to undeclared variable opacitychange
Source file: chrome://global/content/bindings/notification.xml
Line: 174
Whiteboard: [good first bug]
Attached patch PatchSplinter Review
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #232090 - Flags: first-review?(mconners)
Attachment #232090 - Flags: first-review?(mconners) → first-review?(robert.bugzilla)
Comment on attachment 232090 [details] [diff] [review]
Patch

Thanks for the patch
Attachment #232090 - Flags: first-review?(robert.bugzilla) → first-review+
Whiteboard: [good first bug] → [checkin needed]
mozilla/toolkit/content/widgets/notification.xml 	1.6
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha1
Version: unspecified → Trunk
Comment on attachment 232090 [details] [diff] [review]
Patch

Drivers: This is a trivial, virtually risk-free patch. It only inserts two missing variable declarations in order to keep the Error Console cleaner.
Attachment #232090 - Flags: approval1.8.1?
Comment on attachment 232090 [details] [diff] [review]
Patch

a=schrep for drivers.
Attachment #232090 - Flags: approval1.8.1? → approval1.8.1+
Whiteboard: [checkin needed (1.8 branch)]
Status: RESOLVED → VERIFIED
mozilla/toolkit/content/widgets/notification.xml 	1.1.2.5
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: mozilla1.9alpha1 → mozilla1.8.1beta2
Version: Trunk → 1.8 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: