If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Month view: Verbose labels for first/last day shown on other days too (box reuse issue?)

VERIFIED FIXED

Status

Calendar
Calendar Views
--
minor
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: Stefan Sitter, Assigned: Joey Minta)

Tracking

Trunk
x86
Windows 2000

Details

Attachments

(1 attachment)

1.70 KB, patch
Stefan Sitter
: first-review+
Michiel van Leeuwen (email: mvl+moz@)
: second-review+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
Month view: Verbose labels for first/last day shown on other days too (box reuse issue?)

Steps to Reproduce:
1. Start Sunbird with clean profile
2. Switch to Month view (August 2006)
3. Note verbose labels for first/last day of month shown on
   31 Jul, 1 Aug, 31 Aug, 1 Sep
4. Navigate to next month. Navigate to previous month.

Actual Results:
Verbose labels are shown on 31 Jul, 1 Aug, 3 Aug, 4 Aug, 31 Aug, 1 Sep and 2 Sep. 

(Have fun: Do the same in Multiweek view but press Next button many times)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060804 Calendar/0.3a2+
(Assignee)

Comment 1

11 years ago
Created attachment 235481 [details] [diff] [review]
also set to false

Patch fixes our relayout function to also set showMonthLabel to false.  No one had ever exercised this path before, and in doing so, I found a typo that needed to be fixed as well.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #235481 - Flags: second-review?(mvl)
Attachment #235481 - Flags: first-review?(ssitter)
(Reporter)

Comment 2

11 years ago
Comment on attachment 235481 [details] [diff] [review]
also set to false

r1=ssitter
Attachment #235481 - Flags: first-review?(ssitter) → first-review+
Comment on attachment 235481 [details] [diff] [review]
also set to false

r2=mvl
Attachment #235481 - Flags: second-review?(mvl) → second-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

11 years ago
VERIFIED with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060901 Calendar/0.3a2+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.