bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

nsXBLBinding should use importNode instead of cloneNode

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
XBL
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

Trunk
mozilla1.9alpha1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
since it's moving the cloned nodes into a new document.
(Assignee)

Comment 1

12 years ago
Created attachment 232324 [details] [diff] [review]
v1
Attachment #232324 - Flags: superreview?(bugmail)
Attachment #232324 - Flags: review?(bugmail)
Attachment #232324 - Flags: superreview?(bugmail)
Attachment #232324 - Flags: superreview+
Attachment #232324 - Flags: review?(bugmail)
Attachment #232324 - Flags: review+
(Assignee)

Updated

12 years ago
Blocks: 47903
(Assignee)

Comment 2

12 years ago
I had to back this out because the tree went orange. The problem is the security check in ImportNode fails (XBL node coming from a chrome binding, the document imported into being a content document). I could probably use the nsNodeUtils::Clone function that I added in my patch for bug 347524 instead, which doesn't have the security check.
Status: NEW → ASSIGNED
Depends on: 347524

Comment 3

12 years ago
Peter, maybe you can share some wisdom on bug
https://bugzilla.mozilla.org/show_bug.cgi?id=349526
?
Since mid of August, 2006, we are getting permanent crashes in BeOS port  with various stack crawls, but those all have one common thing - calling
nsXBLService::LoadBindings() and then crashing few steps later with segment violation,
in UUID Generator or in GetFactory
(Assignee)

Comment 4

12 years ago
Created attachment 237716 [details] [diff] [review]
v2

This one works better (it doesn't do the security check, which is what we want, right?).
Attachment #232324 - Attachment is obsolete: true
Attachment #237716 - Flags: superreview?(bzbarsky)
Attachment #237716 - Flags: review?(bzbarsky)
Comment on attachment 237716 [details] [diff] [review]
v2

Nice!  r+sr=bzbarsky
Attachment #237716 - Flags: superreview?(bzbarsky)
Attachment #237716 - Flags: superreview+
Attachment #237716 - Flags: review?(bzbarsky)
Attachment #237716 - Flags: review+
(Assignee)

Comment 6

12 years ago
Tree stayed green this time.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
This fix exposed bug 347523.

/be
(In reply to comment #7)
> This fix exposed bug 347523.

Er, bug 355811.

/be

You need to log in before you can comment on or make changes to this bug.