347674 - ReferenceError thrown when accessing exception bound in a catch block in a try block within that catch block

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Testcase coming in a second...

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Testcase

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

Recent regression, from patch for bug 343765.  The bug is that block depth for a with object must be stack index of object named in with statement head, not one more than that index.  This matches block depth for a block (scope) object, which is the index of the first local in the block (empty blocks are never generated).

So the condition for popping block and with objects from the scope chain in the JSOP_SETSP case as patched for bug 343765, OBJ_BLOCK_DEPTH(cx, obj) < i (not <= i) is correct.  The bug is that the "block depth" given to with objects in the case for JSOP_ENTERWITH is off by one (too high). 

Must fix for 1.8.1/fx2/js1.7 -- basic ECMA conformance, core language runtime semantics must be correct.

/be

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 232503 [details] [diff] [review]
fix

mrbkap out of town still, looking for r=shaver -- he knows this code (and the JSOP_SETSP code) too.

/be

Comment 4

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 232503 [details] [diff] [review]
fix

sr=shaver

Comment 5

[Brendan Eich [:brendan]]

Fixed on trunk.

/be

Comment 6

[Bob Clary [:bc] (inactive)]

Checking in regress-347674.js;
/cvsroot/mozilla/js/tests/js1_5/Exceptions/regress-347674.js,v  <--  regress-347674.js
initial revision: 1.1

with edits for bug number and contributor.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 232503 [details] [diff] [review]
fix

a=drivers

Comment 8

[Brendan Eich [:brendan]]

Fixed on the 1.8 branch too.

/be

Comment 9

[Bob Clary [:bc] (inactive)]

verified fixed 1.9 win/mac(ppc|tel)/linux 20060808

Comment 10

[Bob Clary [:bc] (inactive)]

verified fixed 1.8 20060809 mac(ppc|tel)/linux. Unfortunately I don't have windows test results for 20060809 1.8, but verifying anyway.