Closed
Bug 347677
Opened 18 years ago
Closed 18 years ago
Stop dumping to the console on startup. Easy performance win
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mattwillis, Assigned: mattwillis)
Details
Attachments
(1 file)
|
3.62 KB,
patch
|
jminta
:
first-review+
|
Details | Diff | Splinter Review |
calItemModule.js and calImportExportModule.js both dump() to the console on startup telling us what they registered.
This is wonderful, but it slows down startup and pollutes the user's console.log with debugging messages even in non-debug builds.
We should remove the dump()s, or enclose the messages in ifdef MOZ_DEBUG
|
Assignee | |
Comment 1•18 years ago
|
||
This patch removes the four offending dump() lines altogether.
Attachment #232466 -
Flags: first-review?(jminta)
|
|
Assignee | |
Updated•18 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•18 years ago
|
||
Comment on attachment 232466 [details] [diff] [review]
rev0 - removes noisy dump lines
Bonus points for removing dump statements that point to the wrong module. :-) r=jminta
Attachment #232466 -
Flags: first-review?(jminta) → first-review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Patch landed on MOZILLA_1_8_BRANCH and trunk
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 4•18 years ago
|
||
vefyfied with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060820 Calendar/0.3a2+
|
|
||
Updated•18 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•