Closed Bug 347677 Opened 18 years ago Closed 18 years ago

Stop dumping to the console on startup. Easy performance win

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mattwillis, Assigned: mattwillis)

Details

Attachments

(1 file)

calItemModule.js and calImportExportModule.js both dump() to the console on startup telling us what they registered.

This is wonderful, but it slows down startup and pollutes the user's console.log with debugging messages even in non-debug builds.

We should remove the dump()s, or enclose the messages in ifdef MOZ_DEBUG
This patch removes the four offending dump() lines altogether.
Attachment #232466 - Flags: first-review?(jminta)
Status: NEW → ASSIGNED
Comment on attachment 232466 [details] [diff] [review]
rev0 - removes noisy dump lines

Bonus points for removing dump statements that point to the wrong module. :-) r=jminta
Attachment #232466 - Flags: first-review?(jminta) → first-review+
Patch landed on MOZILLA_1_8_BRANCH and trunk

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
vefyfied with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060820 Calendar/0.3a2+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: