Closed Bug 347772 Opened 18 years ago Closed 18 years ago

No focusring for trees

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

(Keywords: regression)

Attachments

(1 file)

Patch for toolkit and xpfe
7.11 KB, patch
neil
: review+
neil
: superreview+
Details | Diff | Splinter Review 
Firefox and Seamonkey trunk, mac os 10.3.9.

When focusing a tree, like the Help Viewer's left pane, you should see a focus ring around the pane. This is not the case anymore.

The effect is achieved with this style rule in mac classic's tree.css (similar with pinstripe):

.focusring:focus > .tree-rows > .tree-bodybox {
    border: 2px solid -moz-mac-focusring;

Bug 201499 is likely the cause here, I backed out the changes in xpfe/global and themes/classic and that made the focus ring appear again (in seamonkey).
Actually this affects all themes on all platforms; the extra stack needs a class name so that we can incorporate it into the style rule.
OS: Mac OS X 10.3 → All
Hardware: Macintosh → All
Summary: [Mac] No focusring for trees → No focusring for trees
This should fix all themes.
Assignee: Jan.Varga → stefanh
Status: NEW → ASSIGNED
Attachment #232904 - Flags: superreview?(neil)
Attachment #232904 - Flags: review?(neil)
Attachment #232904 - Flags: superreview?(neil)
Attachment #232904 - Flags: superreview+
Attachment #232904 - Flags: review?(neil)
Attachment #232904 - Flags: review+
Comment on attachment 232904 [details] [diff] [review]
Patch for toolkit and xpfe

Thanks. Can you check in the patch as well, please?
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: xptoolkit.trees → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: