347790 - [printing] title is always printed as HTMLTitle

Status: VERIFIED FIXED

(Calendar :: Printing, defect)

Description

[Damian Szczepanik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060807 Calendar/0.3a2+

Whatever you type in title inbox at print dialog you alwas see HTMLTitle

Reproducible: Always

Steps to Reproduce:
1. press Ctrl+P
2. type complete title in print dialog
3. Press OK
4. next dialog, press "print" button
   -> instead your title you get HTMLTitle

Actual Results:  
title is predefined can not be changed

Expected Results:  
see screenshot

Comment 1

[Damian Szczepanik]

Attachment: screenshot

Comment 2

[Joey Minta]

This would probably block 0.3 if we can get it confirmed. ->qa

Comment 3

[Matthew (lilmatt) Willis]

Confirmed during all my printing-fu.

Comment 4

[Joey Minta]

Attachment: pass the title around

Patch adds a title argument that we can pass to our print-formatters.

Comment 5

[Matthew (lilmatt) Willis]

Comment on attachment 232970 [details] [diff] [review]
pass the title around

This looks good. I actually will use all of this except the calPrintEngine.js piece in my other bug, so landing this would be good.

r=lilmatt

Comment 6

[Joey Minta]

Comment on attachment 232970 [details] [diff] [review]
pass the title around

-                      [array, size_is(aCount)] in calIItemBase aItems);
+                      [array, size_is(aCount)] in calIItemBase aItems,
+                      in AString aTitle);
At least at an @param comment for the one you're adding. x2

r=dmose with that

Comment 7

[Joey Minta]

Patch checked in.

Comment 8

[Damian Szczepanik]

nice, even polish letters are printed properly

verified