[printing] title is always printed as HTMLTitle

VERIFIED FIXED

Status

Calendar
Printing
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: Damian Szczepanik, Assigned: Joey Minta)

Tracking

({APIchange})

Trunk
APIchange

Details

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060807 Calendar/0.3a2+

Whatever you type in title inbox at print dialog you alwas see HTMLTitle

Reproducible: Always

Steps to Reproduce:
1. press Ctrl+P
2. type complete title in print dialog
3. Press OK
4. next dialog, press "print" button
   -> instead your title you get HTMLTitle

Actual Results:  
title is predefined can not be changed

Expected Results:  
see screenshot
(Reporter)

Updated

12 years ago
Version: unspecified → Trunk
(Reporter)

Comment 1

12 years ago
Created attachment 232587 [details]
screenshot
(Assignee)

Comment 2

12 years ago
This would probably block 0.3 if we can get it confirmed. ->qa
Keywords: qawanted
Confirmed during all my printing-fu.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking0.3+
OS: Windows XP → All
Hardware: PC → All
(Assignee)

Updated

12 years ago
Keywords: qawanted
(Assignee)

Comment 4

12 years ago
Created attachment 232970 [details] [diff] [review]
pass the title around

Patch adds a title argument that we can pass to our print-formatters.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #232970 - Flags: second-review?(dmose)
Attachment #232970 - Flags: first-review?(mattwillis)
Comment on attachment 232970 [details] [diff] [review]
pass the title around

This looks good. I actually will use all of this except the calPrintEngine.js piece in my other bug, so landing this would be good.

r=lilmatt
Attachment #232970 - Flags: first-review?(mattwillis) → first-review+
(Assignee)

Comment 6

12 years ago
Comment on attachment 232970 [details] [diff] [review]
pass the title around

-                      [array, size_is(aCount)] in calIItemBase aItems);
+                      [array, size_is(aCount)] in calIItemBase aItems,
+                      in AString aTitle);
At least at an @param comment for the one you're adding. x2

r=dmose with that
Attachment #232970 - Flags: second-review?(dmose) → second-review+
(Assignee)

Comment 7

12 years ago
Patch checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Keywords: APIchange
(Reporter)

Comment 8

12 years ago
nice, even polish letters are printed properly

verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.