347820 - add "make -k check" unit test to tinderbox tests

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Dave Liebreich [:davel]]

add code to tinderbox client (build-seamonkey-util.pl) to run "make -k check" in the root of the build dir, and fail if errors are reported

Comment 1

[Robert Helmer [:rhelmer]]

Attachment: New tinderbox test: tunit

This test runs all unit tests by running "make check" in mozilla/ (which runs "make check" recursively through the tree).

The test fails if the word FAIL appears in the output, or make returns a non-0 exit code.

Comment 2

[Dave Liebreich [:davel]]

Comment on attachment 232649 [details] [diff] [review]
New tinderbox test: tunit

do you want to guard against $Settings::UnitTestTimeout not being set?

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to comment #2)
> (From update of attachment 232649 [details] [diff] [review] [edit])
> do you want to guard against $Settings::UnitTestTimeout not being set?
> 

It is set in tinder-defaults.pl, so it's assumed that it's always defined (this is how everything else works in tinderbox client anyway :) ).

Comment 4

[Robert Helmer [:rhelmer]]

Attachment: cleanup

Cleanup last patch based on preed's comments:

* include tinder-defaults.pl
* remove unrelated "grabbed_time" line
* rename UnitTest to RunUnitTests

Comment 5

[J. Paul Reed [:preed]]

Comment on attachment 232790 [details] [diff] [review]
cleanup

Looks good; I would change this:

+$RunUnitTests             = 0;  # TUnit

to:

+$RunUnitTests             = 0;  # TUnit; i.e. "make -k check"

r=preed.

Comment 6

[Dave Liebreich [:davel]]

time to turn this on :-)

Comment 7

[Robert Helmer [:rhelmer]]

turned on for argo on the Firefox tree. We're going to roll it out in phases, starting with the trunk.

Comment 8

[Rob Campbell [:rc] (:robcee)]

Tests referenced on the tinderbox are pointing to http://bill/... Should point to a valid web address. Otherwise, nice work!