Closed Bug 347820 Opened 14 years ago Closed 13 years ago

add "make -k check" unit test to tinderbox tests

Categories

(Webtools Graveyard :: Tinderbox, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: davel, Assigned: rhelmer)

References

Details

Attachments

(1 file, 1 obsolete file)

add code to tinderbox client (build-seamonkey-util.pl) to run "make -k check" in the root of the build dir, and fail if errors are reported
Depends on: 347823
Attached patch New tinderbox test: tunit (obsolete) — Splinter Review
This test runs all unit tests by running "make check" in mozilla/ (which runs "make check" recursively through the tree).

The test fails if the word FAIL appears in the output, or make returns a non-0 exit code.
Attachment #232649 - Flags: review?(preed)
Comment on attachment 232649 [details] [diff] [review]
New tinderbox test: tunit

do you want to guard against $Settings::UnitTestTimeout not being set?
(In reply to comment #2)
> (From update of attachment 232649 [details] [diff] [review] [edit])
> do you want to guard against $Settings::UnitTestTimeout not being set?
> 

It is set in tinder-defaults.pl, so it's assumed that it's always defined (this is how everything else works in tinderbox client anyway :) ).
Attached patch cleanupSplinter Review
Cleanup last patch based on preed's comments:

* include tinder-defaults.pl
* remove unrelated "grabbed_time" line
* rename UnitTest to RunUnitTests
Attachment #232649 - Attachment is obsolete: true
Attachment #232790 - Flags: review?(preed)
Attachment #232649 - Flags: review?(preed)
Comment on attachment 232790 [details] [diff] [review]
cleanup

Looks good; I would change this:

+$RunUnitTests             = 0;  # TUnit

to:

+$RunUnitTests             = 0;  # TUnit; i.e. "make -k check"

r=preed.
Attachment #232790 - Flags: review?(preed) → review+
time to turn this on :-)
turned on for argo on the Firefox tree. We're going to roll it out in phases, starting with the trunk.
Tests referenced on the tinderbox are pointing to http://bill/... Should point to a valid web address. Otherwise, nice work!
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.