347854 - UpdateTranslucentWindowAlphaInternal not defined in minimal profile

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Oleg Romashin (:romaxa)]

Steps to Reproduce:
1. cvs -z3 -d :pserver:[e-mail]:/cvsroot co
mozilla/client.mk
2. make -f client.mk checkout

mozconfig:
.....................................
mk_add_options MOZ_CO_PROJECT=xulrunner
ac_add_options --enable-application=xulrunner
ac_add_options --disable-javaxpcom
ac_add_options --disable-js-static-build
ac_add_options --disable-tests
ac_add_options --with-embedding-profile=minimal
.....................................

3. Apply patch from bug 347851 and Bug 330331
https://bugzilla.mozilla.org/attachment.cgi?id=232698
https://bugzilla.mozilla.org/attachment.cgi?id=232694


4. autoconf && ./configure && make

Actual Results:  
Building accessible module failed with errors:

...................................................................
romaxa@romaxa-sr:/home/romaxa/devel/realpc/xulrunner/mozilla_minimal/obj-minimal-i686-pc-linux-gnu/widget/src/gtk2$ make -s
nsWindow.cpp
/home/romaxa/devel/realpc/xulrunner/mozilla_minimal/widget/src/gtk2/nsWindow.cpp: In member function 'virtual nsresult nsWindow::Destroy()':
/home/romaxa/devel/realpc/xulrunner/mozilla_minimal/widget/src/gtk2/nsWindow.cpp:408: warning: ISO C++ forbids casting between pointer-to-function and pointer-to-object
/home/romaxa/devel/realpc/xulrunner/mozilla_minimal/widget/src/gtk2/nsWindow.cpp: In member function 'gboolean nsWindow::OnExposeEvent(GtkWidget*, GdkEventExpose*)':
/home/romaxa/devel/realpc/xulrunner/mozilla_minimal/widget/src/gtk2/nsWindow.cpp:1648: error: 'UpdateTranslucentWindowAlphaInternal' was not declared in this scope
/home/romaxa/devel/realpc/xulrunner/mozilla_minimal/widget/src/gtk2/nsWindow.cpp: At global scope:
/home/romaxa/devel/realpc/xulrunner/mozilla_minimal/widget/src/gtk2/nsWindow.cpp:1428: warning: 'GdkModifierType gdk_keyboard_get_modifiers()' defined but not used
/home/romaxa/devel/realpc/xulrunner/mozilla_minimal/widget/src/gtk2/nsWindow.cpp:1441: warning: 'void gdk_window_flash(GdkWindow*, unsigned int, unsigned int, GdkRegion*)' defined but not used
make[1]: *** [nsWindow.o] Error 1
make: *** [all] Error 2
...................................................................

Expected Results:  
Building finished successefully

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: BUILD_FIX

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: UPDATED fix.

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: UPDATED to trunk

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: BUG fix, without cpp modify's

Comment 5

[Oleg Romashin (:romaxa)]

Attachment: C99 fixes

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Why is this needed?

Comment 7

[Oleg Romashin (:romaxa)]

(In reply to comment #6)
> Why is this needed?
> 

??? Because building failed in embedding-profile=minimal configuration....

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Is someone calling these when MOZ_XUL is not defined? Perhaps those callers should be fixed directly

Comment 9

[Oleg Romashin (:romaxa)]

You mean like it was done here:
https://bugzilla.mozilla.org/attachment.cgi?id=233093
?

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 233562 [details] [diff] [review]
C99 fixes

Hmm, just found this old request.

Update this to trunk though.

Comment 11

[Reed Loden [:reed]]

Attachment: unbitrotten patch

Comment 12

[Oleg Romashin (:romaxa)]

Attachment: Some other kind of FIX.

I tried to remove that MOZ_XUL define at all, and it seems work fine.

Comment 13

[Reed Loden [:reed]]

Checking in widget/src/gtk2/nsWindow.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.236; previous revision: 1.235
done
Checking in widget/src/gtk2/nsWindow.h;
/cvsroot/mozilla/widget/src/gtk2/nsWindow.h,v  <--  nsWindow.h
new revision: 1.79; previous revision: 1.78
done