347888 - profiler does not "guess" at function names without help from the user (loading the source yourself)

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, enhancement)

Description

[Adam L. Peller]

In the profiler, try profiling a page like http://archive.dojotoolkit.org/nightly/tests/widget/test_DatePicker.html

or any Dojo page, and save the report.  You'll see that it has lots of anonymous functions in the report.  Dojo uses this construct for almost all of its code:

dojo.foo = function() {
 ...
}

so almost everything you profile shows up as anonymous.  It would be too expensive to try to "guess" the function names during profiling, as Venkman does in the debugger, but perhaps these references could be "fixed up" after the profile is finished for the functions in the report?

Comment 1

[Robert Ginda]

If you load the source of the file in question in Venkman (by double clicking on it in the Loaded Scripts view), then the name will show up in the profile report.  

Comment 2

[:Gijs (he/him)]

We're aware of that, but we'd like to have the profiler do that by itself if the source hasn't been loaded. I've adjusted the summary slightly to make it slightly more clear. Would that be a valid enhancement request?

Comment 3

[:Gijs (he/him)]

Attachment: Patch

Mini patch.
This just bulk-loads everything it needs, and starts generating report when it's finished. This seems to cure as much as loading everything manually, though for big ajaxy stuff it takes a while - which is exactly why there's a pref for it (which is off by default!). I've made a small whitespace change I just noticed, apart from that I think everything in there is self-explanatory.

r? from Silver. :-)

Comment 4

[James Ross]

Comment on attachment 232940 [details] [diff] [review]
Patch

/toggle-patch-review