Closed Bug 347910 Opened 13 years ago Closed 12 years ago

[FIX]Remove MOZILLA_1_8_BRANCH interfaces on trunk

Categories

(Core :: General, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

()

Details

Attachments

(1 file)

As we get closer to Gecko 1.9, we should look into removing the temporary interfaces that we landed on trunk to make synced branch and trunk work easier.

Similar for the MOZILLA_1_8_BRANCH ifdefs, though I'm happier with keeping those.
Flags: blocking1.9?
Depends on: 385028
Boris, I'm minusing this because it's not a crash, security risk, or dataloss issue.  If you feel strongly about it, please re-nom.
Flags: blocking1.9? → blocking1.9-
Well...  These were introduced to make porting changes to the branch easier, with the idea that they would be removed once we got close to 1.9.  They obfuscate code and should never have gotten review if it were not for the "we'll remove them before 1.9" caveat.

I agree that it will take a (small) amount of time to clean this up, but the idea was to have a large time savings in the early part of the cycle and clean up the mess later.  I do feel pretty strongly that we should clean up the mess.

I guess I'll just take a stab at it.
Attached patch Like soSplinter Review
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #283772 - Flags: superreview?(jst)
Attachment #283772 - Flags: review?(jst)
That removes the interfaces (which I feel somewhat responsible for).  I'm not going to touch the ifdefs, and will just file a separate bug on them.  Note that most of comment 2 applies to the ifdefs, not to the interfaces.
Summary: Remove MOZILLA_1_8_BRANCH intefaces (and ifdefs?) on trunk → [FIX]Remove MOZILLA_1_8_BRANCH intefaces (and ifdefs?) on trunk
Attachment #283772 - Flags: superreview?(jst)
Attachment #283772 - Flags: superreview+
Attachment #283772 - Flags: review?(jst)
Attachment #283772 - Flags: review+
Attachment #283772 - Flags: approval1.9+
Checked in.  Filed bug 398810 and bug 398811.
Summary: [FIX]Remove MOZILLA_1_8_BRANCH intefaces (and ifdefs?) on trunk → [FIX]Remove MOZILLA_1_8_BRANCH interfaces on trunk
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.