347910 - [FIX]Remove MOZILLA_1_8_BRANCH interfaces on trunk

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Boris Zbarsky [:bzbarsky]]

As we get closer to Gecko 1.9, we should look into removing the temporary interfaces that we landed on trunk to make synced branch and trunk work easier.

Similar for the MOZILLA_1_8_BRANCH ifdefs, though I'm happier with keeping those.

Comment 1

[Damon Sicore (:damons)]

Boris, I'm minusing this because it's not a crash, security risk, or dataloss issue.  If you feel strongly about it, please re-nom.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Well...  These were introduced to make porting changes to the branch easier, with the idea that they would be removed once we got close to 1.9.  They obfuscate code and should never have gotten review if it were not for the "we'll remove them before 1.9" caveat.

I agree that it will take a (small) amount of time to clean this up, but the idea was to have a large time savings in the early part of the cycle and clean up the mess later.  I do feel pretty strongly that we should clean up the mess.

I guess I'll just take a stab at it.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 4

[Boris Zbarsky [:bzbarsky]]

That removes the interfaces (which I feel somewhat responsible for).  I'm not going to touch the ifdefs, and will just file a separate bug on them.  Note that most of comment 2 applies to the ifdefs, not to the interfaces.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Checked in.  Filed bug 398810 and bug 398811.