Closed
Bug 347950
Opened 19 years ago
Closed 19 years ago
Adding or removing a search engine doesn't update other tabs' menus
Categories
(Firefox :: Search, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2 beta2
People
(Reporter: pamg.bugs, Assigned: pamg.bugs)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
4.93 KB,
patch
|
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Adding or removing an autodetected search engine should update the searchbox menus for other tabs. Currently it only updates the menu for the current tab.
The 6-line-or-so fix for this bug is contained in the patch for bug 339735, but even if that doesn't land in FF2, this part should.
| Assignee | ||
Updated•19 years ago
|
Flags: blocking-firefox2?
Comment 1•19 years ago
|
||
Blocking on this to make sure it gets fixed!
Flags: blocking-firefox2? → blocking-firefox2+
| Assignee | ||
Comment 2•19 years ago
|
||
This has already been reviewed by ben as part of the larger patch for bug 339735. Additional comments are, of course, welcome.
| Assignee | ||
Comment 3•19 years ago
|
||
Landing on trunk to bake.
| Assignee | ||
Updated•19 years ago
|
Whiteboard: [baking on trunk]
| Assignee | ||
Comment 4•19 years ago
|
||
Comment on attachment 233120 [details] [diff] [review]
Update all tabs when adding or removing an engine
This patch updates each tab's lists of autodetected search engines when such an engine is added to or removed from the permanent list. It is a low-risk patch with no l10n impact.
Attachment #233120 -
Flags: approval1.8.1?
Comment 5•19 years ago
|
||
Comment on attachment 233120 [details] [diff] [review]
Update all tabs when adding or removing an engine
a=drivers, please land on MOZILLA_1_8_BRANCH
Attachment #233120 -
Flags: approval1.8.1? → approval1.8.1+
| Assignee | ||
Comment 6•19 years ago
|
||
Landing on branch.
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [baking on trunk]
You need to log in
before you can comment on or make changes to this bug.
Description
•