347982 - EUC-KR encoder is broken : MSB is stripped off

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Jungshik Shin]

regression due to the patch for bug 336575. patch coming up.

Comment 1

[Jungshik Shin]

Attachment: patch (one liner)

Comment 2

[Jungshik Shin]

Comment on attachment 232871 [details] [diff] [review]
patch (one liner)

Asking for r/sr

I've just confirmed that this patch fixed the bug. 
I also went through the patch for bug 336575 to see if there's a similar 'typo' , but there isn't any more as far as I can tell.

An easy way to reproduce this bug: go to one of Korean search engines that use EUC-KR by default (e.g. http://www.naver.com http://www.empas.com ) and copy'n'paste a Korean word into the search box and press the submit button. Instead of the Korean word you submitted, a gibberish word(made of  numbers and Latin capital letters) will be looked up. Those numbers and letters correspond to the Korean word in EUC-KR with their MSB's stripped off.

Comment 3

[Simon Montagu :smontagu]

Comment on attachment 232871 [details] [diff] [review]
patch (one liner)

Sorry for making this mistake, and thank you very much for spotting and fixing it!

Comment 4

[Jungshik Shin]

thanks for reviews. fix checked in

(In reply to comment #3)
> (From update of attachment 232871 [details] [diff] [review] [edit])
> Sorry for making this mistake, and thank you very much for spotting and fixing
> it!

I should've caught it while reviewing the patch for bug 336575...