Closed
Bug 348007
Opened 19 years ago
Closed 18 years ago
Firefox will crash if use index = -1 to get top level accessible window
Categories
(Firefox :: Disability Access, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
References
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
|
2.13 KB,
patch
|
aaronlev
:
review+
|
Details | Diff | Splinter Review |
Attachment #232896 -
Flags: review?(aaronleventhal)
Summary: Firefox will crash use index -1 to get top level accessible window → Firefox will crash if use index = -1 to get top level accessible window
|
||
Comment 2•19 years ago
|
||
Ginn, is -1 a legal index to pass in, which means get last child?
If so, I think this code should live in refChildCB, because then all the GetChildAt() implementations would benefit.
Note: we don't say this is a legal index in nsIAccessible.
I think it's illegal.
I'm fine if we check it in refChildCB.
note: this patch was taken from nsAccessible::GetChildAt.
And this bug is a potential issue for Firefox on Gnome new builds, this didn't happen just because of a bug of atk-bridge. (gnome bugzilla 350552, http://bugzilla.gnome.org/show_bug.cgi?id=350552)
I think we should also fix this for 18branch and 180branch.
Status: NEW → ASSIGNED
I think it will be safer to patch nsAppRootAccessible.cpp, too.
Attachment #232896 -
Attachment is obsolete: true
Attachment #233048 -
Flags: review?(aaronleventhal)
Attachment #232896 -
Flags: review?(aaronleventhal)
(In reply to comment #3)
> I think we should also fix this for 18branch and 180branch.
>
I recall this comment, the possibility is quite low.
I didn't find a testcase without modify mozilla code.
|
|
||
Updated•19 years ago
|
Attachment #233048 -
Flags: review?(aaronleventhal) → review+
forgot to close it.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•