sv-SE Search Feature Tracking for Firefox 2

VERIFIED FIXED

Status

Mozilla Localizations
sv-SE / Swedish
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: chris hofmann, Assigned: u60234)

Tracking

({verified1.8.1})

unspecified
x86
Windows XP
verified1.8.1
Dependency tree / graph
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

4.16 KB, patch
Pike
: review+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
tracking bug to make sure we get things on the list below working correctly for
each locale:

Full Default Search partner list/order.
primary/secondary search selection behavior
Search codes.
Search Suggests enable/disable for locales where available or not

Updated

11 years ago
Blocks: 350054

Comment 1

11 years ago
Swedish should use a yahoo-se.xml plugin, referring to se.search.yahoo.com, without suggest.
I bet Swedish users are better off with the UK plugins for Amazon, and/or eBay, too. Mikael, Mic, comments?

Comment 2

11 years ago
I'm OK with UK vs US versions assuming Localizer (Mikael) is?
thanks
mic
(Reporter)

Comment 3

11 years ago
Notes from testing Byggets identifierare: Mozilla/5.0 (Windows; U; Windows NT 5.1; sv-SE; rv:1.8.1b2) Gecko/2006082101 Firefox/2.0b2

Google
http://www.google.com/search?q=test&ie=utf-8&oe=utf-8&rls=org.mozilla:sv-SE:official&client=firefox-a
search suggest (föslag) is on, and seems to be returning swedish content

Yahoo
http://search.yahoo.com/search?p=test&ei=UTF-8&fr=moz2

*** http://se.search.yahoo.com/ is available but doesn't seem to be hooked up.  Should the build be switched to this server?

search suggests (föslag) is on, and returns swedish content

Amazon 
http://www.amazon.com/s/103-9872877-2921428?ie=UTF8&tag=mozilla-20&index=blended&link%5Fcode=qs&field-keywords=f%C3%B6rs%C3%A4kringskassan&sourceid=Mozilla-search

*** should we think about switching to UK site like a few of the other euro builds?

Answers
http://www.answers.com/main/ntquery?s=f%C3%B6rs%C3%A4kringskassan&gwp=13

Creative Commons
http://search.creativecommons.org/?q=sweden&sourceid=Mozilla-search

eBay
http://search.ebay.com/sweden_W0QQfrppZ50QQfsopZ1QQmaxrecordsreturnedZ300
** considered uk or other instead? http://www.ebay.co.uk/

Whiteboard: wrong yahoo server?

Comment 4

11 years ago
> search suggest (föslag) is on, and seems to be returning swedish content

Erm, "föslag"? Are you sure? It should be "förslag"...

Comment 5

11 years ago
(In reply to comment #4)
> > search suggest (föslag) is on, and seems to be returning swedish content
> 
> Erm, "föslag"? Are you sure? It should be "förslag"...
> 

Nothing wrong with search.properties, so I guess it was a misspell in comment #4 ;-)

Comment 6

11 years ago
Mikael, Hasse, we'd still need to fix the Yahoo! plugin, and should fix amazon and eBay. See comment 1.
(Assignee)

Comment 7

11 years ago
Created attachment 238237 [details] [diff] [review]
patch

Adds plugins for se.search.yahoo.com, Amazon.co.uk, and eBay.se.
Attachment #238237 - Flags: review?(l10n)
(Reporter)

Comment 8

11 years ago
looks like this is on track.  nominating as a blocker to make sure it get the right attention for review, landing and testing in the last few days.  thanks for the quick patch
Flags: blocking-firefox2?

Updated

11 years ago
Flags: blocking-firefox2? → blocking-firefox2+

Comment 9

11 years ago
Comment on attachment 238237 [details] [diff] [review]
patch

You should be using the en-GB search plugins. Please give them the same file name and make sure that you merely copied them over.
This significantly reduces the amount of work we have to do to review those.

Thanks
Attachment #238237 - Flags: review?(l10n) → review-
(Assignee)

Comment 10

11 years ago
Created attachment 238472 [details] [diff] [review]
patch v2
Attachment #238237 - Attachment is obsolete: true
Attachment #238472 - Flags: review?(l10n)

Comment 11

11 years ago
Comment on attachment 238472 [details] [diff] [review]
patch v2

That looks good.
Attachment #238472 - Flags: review?(l10n) → review+
(Assignee)

Comment 12

11 years ago
Checked in on trunk and branch. Can this bug be closed then?
Keywords: fixed1.8.1

Comment 13

11 years ago
I'll do that tomorrow, let me check for a run of my toolings, which will happen in 3.5 hours. :-/

Comment 14

11 years ago
I checked in a bustage fix, it seems like the yahoo-sv-SE.xml file was in latin-1 and not utf-8. I did an iconv dance and checked that in, hopefully that should make sv-SE go green again.

Unsetting fixed1.8.1 for now, Hasse, please verify that my iconv magic resulted in the right 'Sök'.
Keywords: fixed1.8.1
Whiteboard: wrong yahoo server? → need to verify
(Assignee)

Comment 15

11 years ago
Yes, the "ö" is correctly coded in UTF-8 now. Thanks for the fix!

Comment 16

11 years ago
Thanks to Hasse for cross-checking.

Marking FIXED, please test in a nightly and on a fresh profile that all plugins work as expected and VERIFY.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: need to verify
(Assignee)

Comment 17

11 years ago
Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; sv-SE; rv:1.8.1) Gecko/20060915 BonEcho/2.0.

All plugins worked fine. Search terms with non-ascii chars that are relevant to Swedish all came trough correctly.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1

Updated

11 years ago
Blocks: 316533
You need to log in before you can comment on or make changes to this bug.