348098 - da Search Feature Tracking for Firefox 2

Status: RESOLVED FIXED

(Mozilla Localizations :: da / Danish, defect)

Description

[chris hofmann]

tracking bug to make sure we get things on the list below working correctly for
each locale:

Full Default Search partner list/order.
primary/secondary search selection behavior
Search codes.
Search Suggests enable/disable for locales where available or not

Comment 1

[Axel Hecht [:Pike]]

The current suite of search plugins uses the OpenSearch namespace, but it should use the MozSearch one for starters.
Details can be found on http://developer.mozilla.org/en/docs/Creating_MozSearch_plugins.

In terms of the google plugin, please just add 'google' to list.txt instead of google-dk, the en-US plugin does the right thing.

Comment 2

[Axel Hecht [:Pike]]

Getting the Firefox guys on the bug, too.

Comment 3

[Søren Munk Skrøder (extended hiatus)]

made initial fix to the da search plugins - awaiting verify from Pike

Comment 4

[chris hofmann]

here is what things looked like for da beta2

Google
http://www.google.com/search?q=test&ie=utf-8&oe=utf-8&rls=org.mozilla:da:official&client=firefox-a
search suggest on, danish content returned from search

Yahoo
http://dk.search.yahoo.com/search?p=test&ei=UTF-8&fr=moz2
search suggest on, danish content returned from search

Amazon
http://www.amazon.co.uk/s/026-1354534-0882821?ie=UTF8&keywords=%241&tag=mozilla-20&index=blended&link%5Fcode=qs&field-keywords=test%20&sourceid=Mozilla-search
english content returned from UK site.

Creative Commons
http://search.creativecommons.org/?q=test+&sourceid=Mozilla-search
english content returned

eBay
http://search.ebay.com/test_W0QQfrppZ50QQfsopZ1QQmaxrecordsreturnedZ300
english content returned from US site.

Comment 5

[chris hofmann]

should ebay point at the UK site as the amazon site does?
-> http://www.ebay.co.uk/

are there better alturnatives for the da build for both of these?

Comment 6

[Axel Hecht [:Pike]]

Please look at the amazon.co.uk plugin from en-GB, those should be the same files. For those plugins that you pick up from en-US, would you cvs remove those from the danish l10n dir?

Comment 7

[Søren Munk Skrøder (extended hiatus)]

Pike: 
synced the amazon.co.uk plugin with the en-GB version


"For those plugins that you pick up from en-US, would you cvs remove
those from the danish l10n dir?" >> can you elaborate ... can't see any en-US specific plugins now... 

Comment 8

[Axel Hecht [:Pike]]

answers
creativecommons
eBay
google

are all picked up from en-US. If there is a search plugin with the same name in the en-US directory, it's picked up first. If you look at the Danish build logs, you should see that, too.

Comment 9

[Søren Munk Skrøder (extended hiatus)]

ok .. so i should just cvs remove them -- should their entries be removed from list.txt as well ? 

Comment 10

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #9)
> should their entries be removed from list.txt as well ? 

Nope, it's list.txt that decides which plugins to ship (no matter if they are here or in en-US).

Comment 11

[Søren Munk Skrøder (extended hiatus)]

cvs removed :
 - answers.xml
 - creativecommons.xml
 - eBay.xml
 - google.xml

since they are already provided via en-US

(list.txt remains intact)

Comment 12

[Axel Hecht [:Pike]]

Looks good to me, if there are no further requests, you could close this bug out.

Comment 13

[Søren Munk Skrøder (extended hiatus)]

Closing bug ;-D (yay!)