348153 - Frames from dynamic MathML table children are not made with the right creator

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[rbs]

When a new table-related frame has to be created by nsCSSFrameConstructor::ConstructFrameByDisplayType(), it does not check whether to use the nsMathMLmtableCreator, rather than the generic nsTableCreator. Consequently, a newly appended <mtd> is always treated generically as <td>. I will attach a patch.

Comment 1

[rbs]

Attachment: patch

Comment 2

[rbs]

Attachment: testcase -- append <mtr> and <mtd to an existing <mtable>

Not useful to see the bug -- except if you apply the part of the patch in layout/mathml and not the part in layout/base... in which case the newly added assertion in layout/mathml will fire.

Comment 3

[rbs]

Attachment: patch (add one spot missed in earlier patch)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 233216 [details] [diff] [review]
patch (add one spot missed in earlier patch)

What about the callsites in CreateContinuing* ?

In any case, this looks fine.

Comment 5

[rbs]

Checked in.

> What about the callsites in CreateContinuing* ?

They use the bare NS_NewTable{Row|Cell... etc} calls, and these would have to be converted to calls via a creator. I am not venturing there right now, as page breaks inside a [huge matrix] are not in my radar. The stretchy parentheses around them would have to break to, opening a parandora box (not even TeX does that).

Comment 6

[rbs]

*** Bug 338664 has been marked as a duplicate of this bug. ***