[FIX]Diverting windows into tabs can cause DOM bustage

RESOLVED FIXED in mozilla1.9alpha1

Status

()

P1
normal
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

({fixed1.8.1})

Trunk
mozilla1.9alpha1
x86
Linux
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

12 years ago
STEPS TO REPRODUCE:  Load attached testcase.

EXPECTED RESULTS: Pass

ACTUAL RESULTS: Fail

DETAILS: The problem is that the window provider implementation starts an about:blank load in the window it provides.  This can't be worked around in that implementation easily, since just appending a <xul:browser> into the DOM starts such a load in it; the only way to fix this on the provider side would be to either explicitly call stop() or to nor return from provideWindow until the load completes (which is what happens when we actually open a new window).  Given the difficulty of doing the latter, I think the right solution is to just call stop() in the window watcher.
(Assignee)

Comment 1

12 years ago
Created attachment 233152 [details]
Testcase
(Assignee)

Comment 2

12 years ago
Created attachment 233153 [details] [diff] [review]
Proposed fix
Attachment #233153 - Flags: superreview?(jst)
Attachment #233153 - Flags: review?(benjamin)
(Assignee)

Comment 3

12 years ago
I'd like to land that change on the 1.8 branch too, by the way.
Assignee: nobody → bzbarsky
Priority: -- → P1
Summary: Diverting windows into tabs can cause DOM bustage → [FIX]Diverting windows into tabs can cause DOM bustage
Target Milestone: --- → mozilla1.9alpha

Updated

12 years ago
Attachment #233153 - Flags: review?(benjamin) → review+
Comment on attachment 233153 [details] [diff] [review]
Proposed fix

sr=jst
Attachment #233153 - Flags: superreview?(jst) → superreview+
(Assignee)

Comment 5

12 years ago
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

12 years ago
Comment on attachment 233153 [details] [diff] [review]
Proposed fix

I think we should take this on branch.  This gives us better compat between windows redirected into tabs and just windows.
Attachment #233153 - Flags: approval1.8.1?
Comment on attachment 233153 [details] [diff] [review]
Proposed fix

a=beltzner on behalf of drivers for the mozilla 181 branch
Attachment #233153 - Flags: approval1.8.1? → approval1.8.1+
(Assignee)

Comment 8

12 years ago
Fixed on 1.8 branch.
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.