348362 - Don't focus a tab when mousing-down on its close-button

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Asaf Romano (gone)]

It turns out we focus a tab when its close-button is clicked (mousedown, actually). This causes the themes to show a focus ring while a tab is getting closed.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[Asaf Romano (gone)]

Aaron volunteered to test the impact of this patch on screen readers.

Comment 3

[Asaf Romano (gone)]

Attachment: patch

Comment 4

[Aaron Leventhal]

Just tested this, and unfortunately it breaks focus events for ATK and MSAA.

It would probably work if nsRootAccessible::GetTargetNode() would use the bindingParent for the event. Currently it only does that if the originalTarget is HTML, for the XUL textbox case (which has an anonymous html:input).

As a result, when the focus event comes in for the <hbox>, we don't know what accessible that relates to. Anything that gets a focus event has to have an accessible object or we won't fire an accessible event for it.

I believe that the work Alexander Surkov is doing in bug 344896 for trunk will fix this. XForms has a similar issue.

In the meantime, if you want this fix for branch I think you'll need a way to make sure the focus event occurs for the element it currently has.

Comment 5

[Asaf Romano (gone)]

Comment on attachment 233269 [details] [diff] [review]
patch

Better fix coming.

Comment 6

[Asaf Romano (gone)]

Attachment: a11y-friendly patch

Thanks to Aaron for suggesting this approach.

Comment 7

[Asaf Romano (gone)]

mozilla/toolkit/content/widgets/tabbrowser.xml 1.191
mozilla/toolkit/themes/pinstripe/global/globalBindings.xml 1.16
mozilla/toolkit/themes/pinstripe/global/browser.css 1.14
mozilla/toolkit/themes/winstripe/global/browser.css 1.18

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 233340 [details] [diff] [review]
a11y-friendly patch

a=drivers for MOZILLA_1_8_BRANCH

Comment 9

[Asaf Romano (gone)]

1.8 branch:
mozilla/toolkit/content/widgets/tabbrowser.xml 1.103.2.81
mozilla/toolkit/themes/pinstripe/global/browser.css 1.7.4.10
mozilla/toolkit/themes/pinstripe/global/globalBindings.xml 1.3.12.10
mozilla/toolkit/themes/winstripe/global/browser.css 1.9.4.11

Comment 10

[(not reading, please use [e-mail] instead)]

asaf, could you please double check that this is still fixed on winstripe (after mconnor's landing)?

Comment 11

[Asaf Romano (gone)]

Except bug 348959 is in the middle. But yeah, with the fix for bug 348959, this works right.

Comment 12

[(not reading, please use [e-mail] instead)]

> Except bug 348959 is in the middle. But yeah, with the fix for bug 348959, this
> works right.

thanks asaf.  (yikes, I didn't notice the focus feedback was gone until just now.)