Closed Bug 348437 Opened 13 years ago Closed 12 years ago

Remove nsKillAll.js

Categories

(Core :: XUL, defect, minor)

x86
Windows 2000
defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: mcsmurf, Assigned: standard8)

References

Details

Attachments

(1 file)

Currently xpfe/components/killAll/ gets compiled for all apps that build in xpfe/components/ and have MOZ_HAVE_BROWSER defined. But nsKillAll.js mainly implements nsICmdLineHandler which is only built for apps where MOZ_XUL_APP is not defined.
So I think we should either remove nsKillAll.js from the apps which build with MOZ_XUL_APP defined or fix it so it works with the toolkit/ commandline handler. I don't know about the code under http://lxr.mozilla.org/mozilla/source/toolkit/xre/nsNativeAppSupportWin.cpp#581, it's supposed to catch WM_QUERYENDSESSION messages and then send -killAll to the internal command line handler...?
Blocks: suiterunner
(In reply to comment #0)
> Currently xpfe/components/killAll/ gets compiled for all apps that build in
> xpfe/components/ and have MOZ_HAVE_BROWSER defined. But nsKillAll.js mainly
> implements nsICmdLineHandler which is only built for apps where MOZ_XUL_APP is
> not defined.

Which I think comes down to xulrunner, FireFox and SeaMonkey. Firefox doesn't package it.

> So I think we should either remove nsKillAll.js from the apps which build with
> MOZ_XUL_APP defined or fix it so it works with the toolkit/ commandline
> handler. I don't know about the code under
> http://lxr.mozilla.org/mozilla/source/toolkit/xre/nsNativeAppSupportWin.cpp#581,
> it's supposed to catch WM_QUERYENDSESSION messages and then send -killAll to
> the internal command line handler...?

Firefox have just reimplemented this function (bug 333907) so it doesn't use the -killAll switch any more (which hasn't worked for them for a long time anyway...).

Note at a quick glance I think bug 333907 will have fixed bug 212316 and possibly bug 212251 for trunk at least, but it'd be good if we could test that.


So I vote that we just drop nsKillAll.js rather than re-implement it as I don't see a good use for it.
Removes nsKillAll.js - like I said in comment 1, Firefox doesn't actually package it (though it builds it), SeaMonkey packages it but it no longer works and isn't needed.

From checking mxr, Camino doesn't appear to need it either, so this patch just drops the relevant items that we no longer need.
Assignee: jag → bugzilla
Status: NEW → ASSIGNED
Attachment #273021 - Flags: superreview?(neil)
Attachment #273021 - Flags: review?(benjamin)
Comment on attachment 273021 [details] [diff] [review]
Remove nsKillAll.js

I didn't realise -killAll was for WM_QUERYENDSESSION, I had always thought it was either for xpinstall (to close an existing instance) or to exit turbo mode.
Attachment #273021 - Flags: superreview?(neil) → superreview+
Attachment #273021 - Flags: review?(benjamin) → review+
Updating title to reflect reality.

Patch checked in (I also removed the .cvsignore file so the directory will be deleted).
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Summary: Remove/fix nsKillAll.js for builds with MOZ_XUL_APP=1 set → Remove nsKillAll.js
You need to log in before you can comment on or make changes to this bug.