[FIX]Review comments in bug 285727 never got addressed

RESOLVED FIXED in mozilla1.8.1

Status

()

Core
Layout: Tables
P2
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

({fixed1.8.0.7, fixed1.8.1})

Trunk
mozilla1.8.1
x86
Linux
fixed1.8.0.7, fixed1.8.1
Points:
---
Bug Flags:
blocking1.8.1 +
blocking1.8.0.7 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
The review comment in bug 285727 comment 30 never got addressed.  We really do need to fix that, on trunk and on all branches where bug 285727 landed.
(Assignee)

Comment 1

11 years ago
We shouldn't ship branch Geckos with this problem.  It'll cause unpredictable behavior for web developers...
Flags: blocking1.9?
Flags: blocking1.8.1?
Flags: blocking1.8.0.7?

Updated

11 years ago
Flags: blocking1.8.1? → blocking1.8.1+
Flags: blocking1.8.0.7? → blocking1.8.0.7+
Bernd, can we get a patch that addresses those comments?
Target Milestone: --- → mozilla1.8.1
(Assignee)

Comment 3

11 years ago
Created attachment 233863 [details] [diff] [review]
Patch

bernd is out of town
Attachment #233863 - Flags: superreview?(dbaron)
Attachment #233863 - Flags: review?(dbaron)
(Assignee)

Updated

11 years ago
Assignee: bernd_mozilla → bzbarsky
Priority: -- → P2
Summary: Review comments in bug 285727 never got addressed → [FIX]Review comments in bug 285727 never got addressed
Attachment #233863 - Flags: superreview?(dbaron)
Attachment #233863 - Flags: superreview+
Attachment #233863 - Flags: review?(dbaron)
Attachment #233863 - Flags: review+
(Assignee)

Updated

11 years ago
Attachment #233863 - Flags: approval1.8.1?
Attachment #233863 - Flags: approval1.8.0.7?
(Assignee)

Comment 4

11 years ago
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Comment on attachment 233863 [details] [diff] [review]
Patch

a=mconnor on behalf of drivers for 1.8 branch checkin
Attachment #233863 - Flags: approval1.8.1? → approval1.8.1+
Comment on attachment 233863 [details] [diff] [review]
Patch

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #233863 - Flags: approval1.8.0.7? → approval1.8.0.7+
(Assignee)

Comment 7

11 years ago
Fixed on 1.8 branch.
Keywords: fixed1.8.1

Comment 8

11 years ago
fixed on 1.8.0
Keywords: fixed1.8.0.7
(Assignee)

Updated

11 years ago
Flags: blocking1.9?

Comment 9

11 years ago
Could this have cause bug 349695 ?
(Assignee)

Comment 10

11 years ago
Effectively, yes.
You need to log in before you can comment on or make changes to this bug.