Closed
Bug 348455
Opened 19 years ago
Closed 19 years ago
[FIX]Review comments in bug 285727 never got addressed
Categories
(Core :: Layout: Tables, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.8.1
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: fixed1.8.0.7, fixed1.8.1)
Attachments
(1 file)
|
978 bytes,
patch
|
dbaron
:
review+
dbaron
:
superreview+
dveditz
:
approval1.8.0.7+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
The review comment in bug 285727 comment 30 never got addressed. We really do need to fix that, on trunk and on all branches where bug 285727 landed.
|
Assignee | |
Comment 1•19 years ago
|
||
We shouldn't ship branch Geckos with this problem. It'll cause unpredictable behavior for web developers...
Flags: blocking1.9?
Flags: blocking1.8.1?
Flags: blocking1.8.0.7?
|
|
||
Updated•19 years ago
|
Flags: blocking1.8.1? → blocking1.8.1+
|
||
Updated•19 years ago
|
Flags: blocking1.8.0.7? → blocking1.8.0.7+
|
||
Comment 2•19 years ago
|
||
Bernd, can we get a patch that addresses those comments?
Target Milestone: --- → mozilla1.8.1
|
|
Assignee | |
Comment 3•19 years ago
|
||
bernd is out of town
Attachment #233863 -
Flags: superreview?(dbaron)
Attachment #233863 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•19 years ago
|
Assignee: bernd_mozilla → bzbarsky
Priority: -- → P2
Summary: Review comments in bug 285727 never got addressed → [FIX]Review comments in bug 285727 never got addressed
Attachment #233863 -
Flags: superreview?(dbaron)
Attachment #233863 -
Flags: superreview+
Attachment #233863 -
Flags: review?(dbaron)
Attachment #233863 -
Flags: review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #233863 -
Flags: approval1.8.1?
Attachment #233863 -
Flags: approval1.8.0.7?
|
|
Assignee | |
Comment 4•19 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•19 years ago
|
||
Comment on attachment 233863 [details] [diff] [review]
Patch
a=mconnor on behalf of drivers for 1.8 branch checkin
Attachment #233863 -
Flags: approval1.8.1? → approval1.8.1+
|
|
||
Comment 6•19 years ago
|
||
Comment on attachment 233863 [details] [diff] [review]
Patch
approved for 1.8.0 branch, a=dveditz for drivers
Attachment #233863 -
Flags: approval1.8.0.7? → approval1.8.0.7+
|
|
Assignee | |
Updated•19 years ago
|
Flags: blocking1.9?
|
|
||
Comment 9•19 years ago
|
||
Could this have cause bug 349695 ?
|
|
Assignee | |
Comment 10•19 years ago
|
||
Effectively, yes.
You need to log in
before you can comment on or make changes to this bug.
Description
•